[tests-only]Store upload time after the upload is completed #6083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SwikritiT
requested review from
fschade,
kulmann and
pascalwengerter
as code owners
|
Results for oCISSharingPubExpAndRoles https://drone.owncloud.com/owncloud/web/20599/66/1 |
SwikritiT
force-pushed
the
fix-upload-time
branch
from
f3783b2 to
87c5cf8
Compare
phil-davis
approved these changes
Dec 2, 2021
There was a problem hiding this comment.
Now that I look at the previous code closely, probably httpHelper.put() has returned (and the API request/response sequence has all finished) and then .then() happens. So maybe the previous code was OK.
But writing out the new code in a clear sequential manner helps future readers to see that the upload time stamp is intentionally remembered at the end of the function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR #6047 made some changes in the upload of the file. This PR enhances the changes made by that PR by storing time of upload only after the file has completely been uploaded.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: