-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only][full-ci]Add valid tests that were removed by PR #5973
#6047
Conversation
3fe76aa
to
a29312e
Compare
#5973
@@ -85,3 +85,14 @@ Feature: Versions of a file | |||
And the user uploads overwriting file "lorem.txt" using the webUI | |||
And the user browses to display the "versions" details of file "lorem.txt" | |||
Then the versions list should contain 1 entries | |||
|
|||
@issue-ocis-1328 @disablePreviews | |||
Scenario: sharee can see the versions of a file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty sure this one was deleted as flaky(?) also failes CI in this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. It was skipped previously because of its flakiness but should it be entirely removed? I'll try to find out if it's the test timing problem or the backend issue. if it's the latter we can skip it again and probably create an issue
43bc873
to
e28f253
Compare
After refactoring the function and making it similar to the
oc10 backend
|
e28f253
to
c55c022
Compare
if (timeSinceLastFileUpload <= 1600) { | ||
await client.pause(1600 - timeSinceLastFileUpload) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adjusting this pause time to 1600
fixes the versions issue, the tests are passing even in multiple runs https://drone.owncloud.com/owncloud/web/20534/9/19
I excluded the oc10 test yesterday, can you please re enable it once this is stable? Thanks 😊
|
c55c022
to
b5beb4a
Compare
Kudos, SonarCloud Quality Gate passed! |
Results for oC10SharingPubExpAndRoles https://drone.owncloud.com/owncloud/web/20576/39/1
|
Description
Some of the tests that are still valid were accidentally removed by PR #5973. This PR re-adds those tests. One of the added tests relating to versions was flaky so a little pause time is added and the function is refactored accordingly
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: