-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix yarn build:w auto reload with docker crashing docker completly #6382
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Results for oCISSharingAndUpload https://drone.owncloud.com/owncloud/web/22523/66/1
|
Results for oCISFiles1 https://drone.owncloud.com/owncloud/web/22523/55/1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤩 LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me it doesn't 😞 Can someone else also try it out?
Edit: at least I still see the Oops. Something went wrong.
error page of hell. If that fix was not about that I can't review because I never experienced "total crash" issues with docker. Might be M1 related - I'm on Intel.
Checked it again. Still broken for me. The change to the rollup config is good, but it doesn't solve the issue, at least for me, so the changelog item is not appropriate. For me, steps to reproduce:
|
for me its working i dont know why, will look into this |
i digged a bit deeper too with following setup:
In my case, I haven't had the problem in the past 10 minutes tested vie oc10 and ocis. @kulmann can as you're using it this still does not work for your env we need to dig into following:
|
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
would break the production bundle in current PR state
Superseded by #6855 |
Description
As you may noticed our workflow with docker was completly broken and unusable sadly.
This should finally fix it :) :)
Types of changes