Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yarn build:w auto reload with docker crashing docker completly #6382

Closed
wants to merge 4 commits into from

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented Feb 8, 2022

Description

As you may noticed our workflow with docker was completly broken and unusable sadly.
This should finally fix it :) :)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@update-docs
Copy link

update-docs bot commented Feb 8, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ownclouders
Copy link
Contributor

Results for oCISSharingAndUpload https://drone.owncloud.com/owncloud/web/22523/66/1
The following scenarios passed on retry:

  • webUIUpload/upload.feature:94

@ownclouders
Copy link
Contributor

Results for oCISFiles1 https://drone.owncloud.com/owncloud/web/22523/55/1
The following scenarios passed on retry:

  • webUIDeleteFilesFolders/deleteFilesFolders.feature:253

fschade
fschade previously approved these changes Feb 8, 2022
Copy link
Contributor

@fschade fschade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩 LGTM

Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it doesn't 😞 Can someone else also try it out?

Edit: at least I still see the Oops. Something went wrong. error page of hell. If that fix was not about that I can't review because I never experienced "total crash" issues with docker. Might be M1 related - I'm on Intel.

@kulmann
Copy link
Contributor

kulmann commented Feb 8, 2022

For me it doesn't 😞 Can someone else also try it out?

Edit: at least I still see the Oops. Something went wrong. error page of hell. If that fix was not about that I can't review because I never experienced "total crash" issues with docker. Might be M1 related - I'm on Intel.

Checked it again. Still broken for me. The change to the rollup config is good, but it doesn't solve the issue, at least for me, so the changelog item is not appropriate.

For me, steps to reproduce:

  • wipe everything-docker (system prune and volume prune), restart docker engine completely
  • yarn build:w
  • docker-compose up -d
  • check browser, oc10 and ocis work with web
  • kill yarn build:w
  • run yarn build:w
  • check browser, oc10 and ocis show Opps. something went wrong error page.
  • 💥

@lookacat
Copy link
Contributor Author

lookacat commented Feb 8, 2022

for me its working i dont know why, will look into this

@fschade
Copy link
Contributor

fschade commented Feb 8, 2022

i digged a bit deeper too with following setup:

  • os: monterey 12.1 Beta (21C5021h)
  • hardware: m1 macBook air 8gb ram
  • Docker: Docker Desktop 4.4.2 (73305
  • Docker: Docker Compose V2 enabled
  • Docker: gRPC FUSE for file sharing
  • Docker: macOs Big Sur virtualization is used instead of hypervsisor

In my case, I haven't had the problem in the past 10 minutes tested vie oc10 and ocis.

@kulmann can as you're using docker-compose instead of docker compose, can you check if you have enabled Docker Compose V2 enabled in the docker general settings.

it this still does not work for your env we need to dig into following:

  • it started to be problematic ~ when we introduced the new icons.
    • can you test it without syncing the icons in docker-compose.yml
  • oc10 chowns the files located in /mnt/* to www-data, we need to test if this is the problem since docker uses extended attributes for gRpc fuse shares

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kulmann kulmann dismissed fschade’s stale review February 9, 2022 08:49

would break the production bundle in current PR state

@kulmann kulmann marked this pull request as draft February 11, 2022 08:21
@kulmann
Copy link
Contributor

kulmann commented May 4, 2022

Superseded by #6855

@kulmann kulmann closed this May 4, 2022
@pascalwengerter pascalwengerter deleted the resolve-rollup-crashing-docker branch July 5, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants