-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[full-ci] fix docker dev env and decrease build time #6855
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what I need to do to not see this Oops. Something went wrong.
page from hell anymore with this PR. 🤔 Anything to consider? Like still something to be done as first step? I tried with running yarn build:w
first and after that running docker compose up -d
. On first build it worked, killing the watcher and rebuilding results in the error page again. Docker env was cleaned before, up to date images pulled.
nice edgecase, thx i haven't tried to kill the rollup watch while docker keeps running... Ill give it a try tomorrow :), i converted the pr back into draft state for the moment. |
Results for oCISSharingPublic2 https://drone.owncloud.com/owncloud/web/25210/69/1 |
Haven't tried with this PR, but I'm using |
@kulmann, can you give it another try, i found out that some caching is going on. |
@fschade and @dschmidt that's what I already have, starting the docker env with
|
@kulmann lets try it out together if time permits.... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works for me 🤩
fix faulty oc10 docker file sync
Co-authored-by: Benedikt Kulmann <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
I cancelled the drone job https://drone.owncloud.com/owncloud/web/25231 since it passed the e2e tests. As this PR doesn't change any code it's sufficient for me to know that any end to end testing succeeded. Which it did. Force merging now. |
Description
We've introduced a broken build build pipeline which had led to long waiting times during development.
This pr fixes:
Related Issue
Motivation and Context
I want to use my time wisely ;)
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: