Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] fix docker dev env and decrease build time #6855

Merged
merged 3 commits into from
May 4, 2022

Conversation

fschade
Copy link
Contributor

@fschade fschade commented May 2, 2022

Description

We've introduced a broken build build pipeline which had led to long waiting times during development.

This pr fixes:

  • re-build time increased on every cycle
  • docker on oc10 stopped working and got stuck on file-change

Related Issue


Motivation and Context

I want to use my time wisely ;)

How Has This Been Tested?

  • local dev env on macOs and latest docker

Screenshots (if appropriate):


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Technical debt

Checklist:


Open tasks:

  • Test on different OS

@fschade fschade requested a review from pascalwengerter as a code owner May 2, 2022 16:00
@fschade fschade requested a review from kulmann May 2, 2022 16:00
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what I need to do to not see this Oops. Something went wrong. page from hell anymore with this PR. 🤔 Anything to consider? Like still something to be done as first step? I tried with running yarn build:w first and after that running docker compose up -d. On first build it worked, killing the watcher and rebuilding results in the error page again. Docker env was cleaned before, up to date images pulled.

changelog/unreleased/bugfix-build-time Outdated Show resolved Hide resolved
@fschade
Copy link
Contributor Author

fschade commented May 2, 2022

images

nice edgecase, thx i haven't tried to kill the rollup watch while docker keeps running...
i only tested the default development flow (change files).

Ill give it a try tomorrow :), i converted the pr back into draft state for the moment.

@fschade fschade marked this pull request as draft May 2, 2022 18:12
@ownclouders
Copy link
Contributor

ownclouders commented May 2, 2022

Results for oCISSharingPublic2 https://drone.owncloud.com/owncloud/web/25210/69/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@dschmidt
Copy link
Member

dschmidt commented May 3, 2022

Not sure what I need to do to not see this Oops. Something went wrong. page from hell anymore with this PR. thinking Anything to consider? Like still something to be done as first step? I tried with running yarn build:w first and after that running docker compose up -d. On first build it worked, killing the watcher and rebuilding results in the error page again. Docker env was cleaned before, up to date images pulled.

Haven't tried with this PR, but I'm using docker-compose up -d --force-recreate that usually works reliably for me

@fschade
Copy link
Contributor Author

fschade commented May 3, 2022

@kulmann, can you give it another try, i found out that some caching is going on.
Please test wit disabled cache in console network tab.

Bildschirmfoto 2022-05-03 um 12 10 50

@kulmann
Copy link
Contributor

kulmann commented May 3, 2022

@fschade and @dschmidt that's what I already have, starting the docker env with --force-recreate always. And Disable cache in the browser network tab is always ticked since forever. Still the same error page. Browser console prints

index.html:19          GET http://host.docker.internal:8080/index.php/apps/web/js/require.js?1651573570081 net::ERR_ABORTED 404 (Not Found)

@fschade
Copy link
Contributor Author

fschade commented May 3, 2022

@kulmann lets try it out together if time permits....

@fschade fschade force-pushed the decrease-dev-time branch from 1630b09 to cb1f73b Compare May 3, 2022 15:22
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me 🤩

@kulmann kulmann changed the title fix docker dev env and decrease build time [full-ci] fix docker dev env and decrease build time May 3, 2022
@kulmann kulmann force-pushed the decrease-dev-time branch from cb1f73b to ae2b0ac Compare May 3, 2022 18:36
@kulmann kulmann force-pushed the decrease-dev-time branch from ae2b0ac to e93f0ea Compare May 4, 2022 06:35
@kulmann kulmann marked this pull request as ready for review May 4, 2022 06:44
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kulmann
Copy link
Contributor

kulmann commented May 4, 2022

I cancelled the drone job https://drone.owncloud.com/owncloud/web/25231 since it passed the e2e tests. As this PR doesn't change any code it's sufficient for me to know that any end to end testing succeeded. Which it did. Force merging now.

@kulmann kulmann merged commit dd190a2 into master May 4, 2022
@delete-merged-branch delete-merged-branch bot deleted the decrease-dev-time branch May 4, 2022 07:02
@micbar micbar mentioned this pull request May 5, 2022
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants