Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design polishing: Set a fixed aspect ratio for spaces image #6829

Merged
merged 4 commits into from
May 3, 2022

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented Apr 28, 2022

Description

See #6555 (last point)

Related Issue

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@update-docs
Copy link

update-docs bot commented Apr 28, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@lookacat lookacat force-pushed the fix-space-projects-aspect-ratio branch from 6d88c73 to df256e6 Compare April 28, 2022 10:17
@lookacat lookacat changed the title Set a fixed aspect ratio for spaces image Enhancement: Set a fixed aspect ratio for spaces image Apr 28, 2022
@lookacat lookacat changed the title Enhancement: Set a fixed aspect ratio for spaces image Design polishing: Set a fixed aspect ratio for spaces image Apr 28, 2022
@lookacat lookacat marked this pull request as ready for review April 28, 2022 10:23
@ownclouders
Copy link
Contributor

Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/24981/12/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/24981/tracing/unstructured-collection-of-testable-space-interactions-alice-2022-4-28-10-44-22.zip

@lookacat lookacat force-pushed the fix-space-projects-aspect-ratio branch from 57c2e0b to b8d55c7 Compare May 3, 2022 07:26
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kulmann kulmann merged commit 1985fa5 into master May 3, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix-space-projects-aspect-ratio branch May 3, 2022 09:34
@micbar micbar mentioned this pull request May 5, 2022
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants