Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design polishing: Set a fixed aspect ratio for spaces image #6829

Merged
merged 4 commits into from
May 3, 2022
Merged

Design polishing: Set a fixed aspect ratio for spaces image #6829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2ee1c32
Set a fixed aspect ratio for spaces image
lookacat Apr 28, 2022
1ac5be5
Add changelog
lookacat Apr 28, 2022
b8d55c7
Use class instead of tag, Update snapshots
lookacat Apr 28, 2022
b4ff8b7
Fix snapshot tests
lookacat May 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions changelog/unreleased/enhancement-fixed-aspect-ratio-spaces-image
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Enhancement: Fixed aspect ratio for spaces images

We've set the spaces images to a fixed aspect ratio to make
sure that the same part of the image is always displayed.

https://github.com/owncloud/web/pull/6829
https://github.com/owncloud/web/issues/6555
9 changes: 6 additions & 3 deletions packages/web-app-files/src/views/spaces/Projects.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,8 +285,7 @@ export default defineComponent({
}

.oc-card-media-top {
width: 100%;
height: 150px;
aspect-ratio: 16/9;
}

.oc-card-media-top a {
Expand All @@ -302,7 +301,7 @@ export default defineComponent({

.space-image {
width: 100%;
height: 150px;
aspect-ratio: 16/9;
object-fit: cover;
}

Expand All @@ -317,5 +316,9 @@ export default defineComponent({
.space-disabled-indicator {
z-index: 999;
}

.spaces-list-projects {
aspect-ratio: 16/9;
}
}
</style>