[full-ci] Improve error message for internal links on unaccepted shares #7814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Results for oCISBasic https://drone.owncloud.com/owncloud/web/29148/52/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUIPrivateLinks-accessingPrivateLinks_feature-L35.png |
JammingBen
force-pushed
the
private-link-on-unaccepted-share
branch
from
1d50f4d to
a1d7d8f
Compare
JammingBen
changed the title
JammingBen
changed the title
JammingBen
force-pushed
the
private-link-on-unaccepted-share
branch
from
a1d7d8f to
025542d
Compare
|
Just a nitpick, but I'm not really a fan of the filename as a centered headline but still being a part of the following text. @tbsbdr thoughts? |
|
@janackermann might have had the same thought though you wondered if it works with different languages. Lets change it to:
note: If you have the possibility, a more specific "This file... " or "This folder ..." would be better than just "item" thx @dschmidt for raising feedback |
dschmidt
reviewed
Oct 18, 2022
|
SonarCloud Quality Gate failed. |
dschmidt
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The error message when resolving an internal link to an unaccepted share has been improved for a better UX.
Also, the resolving page has been redesigned.
Screenshots
Related Issue
Types of changes