Prepare for pip / conda builds #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add an __init__.py - Add a __version__ attribute - Remove unnecessary distutils directives from cython files - Remove unnecessary setupGraspiCython.py file
Adding the cpp file is not necessary as Cython is widely available and it is already a dependency for this package.
This was referenced Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparing repository for pip and conda builds. Generally make the setup.py a little cleaner.
graspi/graspi.cppas not really necessary and potential for confusion. Also, can't realistically use GraSPI without a working Cython implementation anyway. Updated.gitignoreto reflect this.cythonizeGraspi/tograspi/to fit in with typical Python package structure. Also this makes it work without an installed version of GraSPI for development purposes.__version__attribute to mirror other python projects