refactor(linter): improve jsx-a11y/heading-has-content (#9089)

- Enable a repaired test case
- Simplify logical code

crates/oxc_linter/src/rules/jsx_a11y/heading_has_content.rs

@@ -48,7 +48,7 @@ declare_oxc_lint!(
     /// this could either confuse users or even prevent them
     /// from accessing information on the page's structure.
     ///
-    /// ### Example
+    /// ### Examples
     ///
     /// Examples of **incorrect** code for this rule:
     /// ```jsx
@@ -85,14 +85,10 @@ impl Rule for HeadingHasContent {
             return;
         };
 
-        // let JSXElementName::Identifier(iden) = &jsx_el.name else {
-        //     return;
-        // };
+        let name = get_element_type(ctx, jsx_el);
+        let name = name.as_ref();
 
-        // let name = iden.name.as_str();
-        let name = &get_element_type(ctx, jsx_el);
-
-        if !DEFAULT_COMPONENTS.iter().any(|&comp| comp == name)
+        if DEFAULT_COMPONENTS.binary_search(&name).is_err()
             && !self
                 .components
                 .as_ref()
@@ -178,8 +174,7 @@ fn test() {
         (r"<Heading>{undefined}</Heading>", Some(components()), None),
         // CUSTOM ELEMENT TESTS FOR COMPONENTS SETTINGS
         (r"<Heading />", None, Some(settings())),
-        // TODO: This should be failed but pass for now
-        // (r#"<h1><CustomInput type="hidden" /></h1>"#, None, Some(settings())),
+        (r#"<h1><CustomInput type="hidden" /></h1>"#, None, Some(settings())),
     ];
 
     Tester::new(HeadingHasContent::NAME, HeadingHasContent::PLUGIN, pass, fail)

crates/oxc_linter/src/snapshots/jsx_a11y_heading_has_content.snap

@@ -63,3 +63,10 @@ source: crates/oxc_linter/src/tester.rs
    · ───────────
    ╰────
   help: Provide screen reader accessible content when using heading elements.
+
+  ⚠ eslint-plugin-jsx-a11y(heading-has-content): Headings must have content and the content must be accessible by a screen reader.
+   ╭─[heading_has_content.tsx:1:1]
+ 1 │ <h1><CustomInput type="hidden" /></h1>
+   · ────
+   ╰────
+  help: Provide screen reader accessible content when using heading elements.