Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(linter): improve jsx-a11y/heading-has-content #9089

Merged

Conversation

shulaoda
Copy link
Member

  • Enable a repaired test case
  • Simplify logical code

Copy link

graphite-app bot commented Feb 13, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Feb 13, 2025
@shulaoda shulaoda force-pushed the refactor/jsx-a11y-heading-has-content branch from 4f32bfe to e9c5417 Compare February 13, 2025 17:18
@shulaoda shulaoda force-pushed the refactor/jsx-a11y-heading-has-content branch from e9c5417 to 8f257ef Compare February 14, 2025 07:40
@shulaoda shulaoda force-pushed the refactor/jsx-a11y-heading-has-content branch from 8f257ef to 3c903c2 Compare February 14, 2025 14:40
Copy link

codspeed-hq bot commented Feb 14, 2025

CodSpeed Performance Report

Merging #9089 will not alter performance

Comparing shulaoda:refactor/jsx-a11y-heading-has-content (3c903c2) with main (23f53c0)

Summary

✅ 33 untouched benchmarks

@Sysix Sysix merged commit 9ca22f4 into oxc-project:main Feb 15, 2025
26 checks passed
@shulaoda shulaoda deleted the refactor/jsx-a11y-heading-has-content branch February 15, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants