Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode extension: default oxc_language_server.configPath seems wrong #5802

Closed
greeeg opened this issue Sep 16, 2024 · 4 comments
Closed

VSCode extension: default oxc_language_server.configPath seems wrong #5802

greeeg opened this issue Sep 16, 2024 · 4 comments
Labels
C-bug Category - Bug

Comments

@greeeg
Copy link

greeeg commented Sep 16, 2024

Hi 👋

While trying to move part of my linting config from eslint to oxlint, I did not understand why removing the no-console rule from .eslintrc & adding it to .oxlintrc.json did not trigger an error in my VSCode editor while it was triggering it properly running the oxlint CLI.

After a short investigating, I discovered that the default config path used by the OXC VSCode language server was .eslintrc.

It means that the oxlint language server was using my legacy eslint config instead of the new appropriate one. Should we change the default config path to be the filename documented here or at least explain that the configuration file used can be changed using VSCode settings.json file? Many thanks!

@greeeg greeeg added the C-bug Category - Bug label Sep 16, 2024
@pumano
Copy link
Contributor

pumano commented Oct 9, 2024

@DonIsaac I can change default value to .oxlintrc.json, because documentation tells about .oxlintrc.json not about .eslintrc.

Looks like good first issue for me)

How do you think about it?

@DonIsaac
Copy link
Contributor

DonIsaac commented Oct 9, 2024

No-work-required eslint migration is a large goal for us. I'm down with checking for an .oxlintrc.json file and falling back to .eslintrc.

As a note: a lot of our users use oxlint.json as their config file name.

@pumano
Copy link
Contributor

pumano commented Oct 10, 2024

@DonIsaac OK would be good to have checking for .oxlintrc.json too. So I close my pull request

@Boshen
Copy link
Member

Boshen commented Nov 25, 2024

#7442

@Boshen Boshen closed this as completed Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category - Bug
Projects
None yet
4 participants