Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(language_server): auto detect oxlint config #7256

Closed

Conversation

Sysix
Copy link
Collaborator

@Sysix Sysix commented Nov 12, 2024

closes #5802

Copy link

graphite-app bot commented Nov 12, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-editor Area - Editor and Language Server C-enhancement Category - New feature or request labels Nov 12, 2024
@Sysix Sysix marked this pull request as ready for review November 12, 2024 14:49
@camc314 camc314 requested a review from Boshen November 14, 2024 13:12
@nrayburn-tech
Copy link
Contributor

nrayburn-tech commented Nov 16, 2024

#4600 is an issue for the CLI equivalent of this and #4924 is the relevant PR for that.

Should probably review merging the CLI PR in if this goes in.

@Sysix
Copy link
Collaborator Author

Sysix commented Nov 19, 2024

good point, I tried to add it into CLI #7348. This PR depends on another one :)

Back to "Draft" until CLI is merged

@Sysix Sysix marked this pull request as draft November 19, 2024 17:33
@Sysix
Copy link
Collaborator Author

Sysix commented Nov 23, 2024

Because in #7348 we decided to only check for .oxlintrc.json, I will close this PR and change the default value on the client side: #7442

@Sysix Sysix closed this Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-editor Area - Editor and Language Server C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VSCode extension: default oxc_language_server.configPath seems wrong
3 participants