Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linter benchmarks run on PRs with no changes related to linter #6824

Closed
overlookmotel opened this issue Oct 23, 2024 · 1 comment · Fixed by #6840
Closed

Linter benchmarks run on PRs with no changes related to linter #6824

overlookmotel opened this issue Oct 23, 2024 · 1 comment · Fixed by #6840
Labels
C-bug Category - Bug

Comments

@overlookmotel
Copy link
Contributor

overlookmotel commented Oct 23, 2024 •
edited
Loading

#6705 was intended to prevent linter benchmarks running on PRs which don't touch any code related to the linter.

It doesn't seem to be working. Linter benchmarks ran on #6814 which only changes 1 file in oxc_traverse.

@DonIsaac Any idea why this is?
@overlookmotel overlookmotel added the C-bug Category - Bug label Oct 23, 2024
Boshen added a commit that referenced this issue Oct 24, 2024
@Boshen
ci(benchmark): fix linter benchmark triggering on unrelated files
b980229 
fixes #6824
@Boshen Boshen mentioned this issue Oct 24, 2024
Merged
@Boshen
Copy link
Member

Boshen commented Oct 24, 2024

path negation doesn't work in picomatch.

Boshen added a commit that referenced this issue Oct 24, 2024
@Boshen
ci(benchmark): fix linter benchmark triggering on unrelated files
e7d5b95 
fixes #6824
@Boshen Boshen closed this as completed in fb01208 Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category - Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci(benchmark): fix linter benchmark triggering on unrelated files oxc-project/oxc
2 participants
@overlookmotel @Boshen