Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(linter): skip linter benchmarks on unrelated file changes #6705

Merged

Conversation

DonIsaac
Copy link
Contributor

@DonIsaac DonIsaac commented Oct 20, 2024

Skip building/running linter benchmarks on PRs that only change the transformer, ID, formatter, or the minifier.

Copy link

graphite-app bot commented Oct 20, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@DonIsaac DonIsaac requested a review from Boshen October 20, 2024 16:07
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @DonIsaac and the rest of your teammates on Graphite Graphite

@DonIsaac DonIsaac marked this pull request as ready for review October 20, 2024 16:07
@DonIsaac DonIsaac force-pushed the don/10-20-ci_skip_linter_benchmarks_on_unrelated_file_changes branch from 48b22e1 to 20633ec Compare October 20, 2024 16:08
Copy link

codspeed-hq bot commented Oct 20, 2024

CodSpeed Performance Report

Merging #6705 will not alter performance

Comparing don/10-20-ci_skip_linter_benchmarks_on_unrelated_file_changes (20633ec) with main (6a76ea8)

Summary

✅ 30 untouched benchmarks

@overlookmotel overlookmotel changed the title ci: skip linter benchmarks on unrelated file changes ci(linter): skip linter benchmarks on unrelated file changes Oct 20, 2024
@overlookmotel
Copy link
Contributor

overlookmotel commented Oct 20, 2024

This is a really good idea. The linter benchmarks are always the slowest to complete.

I'm not familiar with dorny/paths-filter, so can I just check the filter is the right way around? i.e. it will run linter benchmarks if:

  • PR changes at least one file, not including files in oxc_transformer etc.

And not:

  • PR does not change any files in oxc_transformer etc.

It's possible a PR might make changes to both the linter and the transformer, and we'd want linter benchmarks to run in that case.

@DonIsaac
Copy link
Contributor Author

This is a really good idea. The linter benchmarks are always the slowest to complete.

I'm not familiar with dorny/paths-filter, so can I just check the filter is the right way around? i.e. it will run linter benchmarks if:

  • PR changes at least one file, not including files in oxc_transformer etc.

And not:

  • PR does not change any files in oxc_transformer etc.

It's possible a PR might make changes to both the linter and the transformer, and we'd want linter benchmarks to run in that case.

I believe so. I followed the example in CI / Conformance. I'd like a review from @Boshen before merging just to make sure this works as I think it does.

@Boshen Boshen merged commit f05a273 into main Oct 21, 2024
16 of 18 checks passed
@Boshen Boshen deleted the don/10-20-ci_skip_linter_benchmarks_on_unrelated_file_changes branch October 21, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants