Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(transformer/typescript): declare class incorrectly preserved as runtime class #3997

Merged
merged 1 commit into from
Jul 1, 2024
Merged

fix(transformer/typescript): declare class incorrectly preserved as runtime class #3997

merged 1 commit into from
Jul 1, 2024

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Jul 1, 2024 •
edited
Loading

fix: #3993

@Dunqing Graphite App
Copy link
Member Author

Dunqing commented Jul 1, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Dunqing and the rest of your teammates on Graphite Graphite

@Dunqing Dunqing mentioned this pull request Jul 1, 2024
Merged
@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label Jul 1, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Jul 1, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jul 1, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #3997 will not alter performance

Comparing 07-01-fix_transformer_typescript_declare_class_incorrectly_preserved_as_runtime_class (bdee156) with main (d0eac46)

Summary

✅ 28 untouched benchmarks

@Dunqing Dunqing force-pushed the 07-01-fix_transformer_typescript_declare_class_incorrectly_preserved_as_runtime_class branch from 97726fa to bf04cad Compare July 1, 2024 14:37
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jul 1, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Jul 1, 2024 •
edited
Loading

Merge activity

  • Jul 1, 10:39 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jul 1, 10:48 AM EDT: Boshen added this pull request to the Graphite merge queue.
  • Jul 1, 10:54 AM EDT: The Graphite merge queue couldn't merge this PR because it had conflicts with the trunk branch.
  • Jul 1, 2:58 PM UTC: The merge label 'merge' was removed. This PR will no longer be merged by the Graphite merge queue
  • Jul 1, 11:00 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jul 1, 11:15 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jul 1, 11:58 AM EDT: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
  • Jul 1, 12:03 PM EDT: Boshen added this pull request to the Graphite merge queue.
  • Jul 1, 12:09 PM EDT: Boshen merged this pull request with the Graphite merge queue.

@Dunqing Dunqing force-pushed the 07-01-fix_transformer_typescript_missing_initializer_for_class_constructor_arguments_with_private_and_protected_modifier branch from f84470d to 771e001 Compare July 1, 2024 14:41
@Dunqing Dunqing force-pushed the 07-01-fix_transformer_typescript_declare_class_incorrectly_preserved_as_runtime_class branch from bf04cad to 33bd025 Compare July 1, 2024 14:41
@Dunqing Dunqing linked an issue Jul 1, 2024 that may be closed by this pull request
transformer: declare class incorrectly preserved as runtime class #3993
Closed
@Dunqing Dunqing force-pushed the 07-01-fix_transformer_typescript_missing_initializer_for_class_constructor_arguments_with_private_and_protected_modifier branch from 771e001 to abddd20 Compare July 1, 2024 14:49
@Dunqing Dunqing force-pushed the 07-01-fix_transformer_typescript_declare_class_incorrectly_preserved_as_runtime_class branch from 33bd025 to 3cbdcc8 Compare July 1, 2024 14:49
@Dunqing Dunqing mentioned this pull request Jul 1, 2024
Merged
@Dunqing Dunqing force-pushed the 07-01-fix_transformer_typescript_missing_initializer_for_class_constructor_arguments_with_private_and_protected_modifier branch from abddd20 to cf34785 Compare July 1, 2024 14:53
@Dunqing Dunqing force-pushed the 07-01-fix_transformer_typescript_declare_class_incorrectly_preserved_as_runtime_class branch from 3cbdcc8 to ff9eff6 Compare July 1, 2024 14:53
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 1, 2024
@Boshen Boshen force-pushed the 07-01-fix_transformer_typescript_missing_initializer_for_class_constructor_arguments_with_private_and_protected_modifier branch from cf34785 to ad3ecbe Compare July 1, 2024 14:55
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jul 1, 2024 — with Graphite App
@Dunqing Dunqing force-pushed the 07-01-fix_transformer_typescript_missing_initializer_for_class_constructor_arguments_with_private_and_protected_modifier branch from ad3ecbe to a8de816 Compare July 1, 2024 15:04
@Dunqing Dunqing force-pushed the 07-01-fix_transformer_typescript_declare_class_incorrectly_preserved_as_runtime_class branch from ff9eff6 to fe720b0 Compare July 1, 2024 15:05
@Boshen Boshen force-pushed the 07-01-fix_transformer_typescript_missing_initializer_for_class_constructor_arguments_with_private_and_protected_modifier branch from a8de816 to da4f66f Compare July 1, 2024 15:06
@Dunqing Dunqing force-pushed the 07-01-fix_transformer_typescript_missing_initializer_for_class_constructor_arguments_with_private_and_protected_modifier branch from da4f66f to a8de816 Compare July 1, 2024 15:08
@Boshen Boshen force-pushed the 07-01-fix_transformer_typescript_missing_initializer_for_class_constructor_arguments_with_private_and_protected_modifier branch from a8de816 to a50ce3d Compare July 1, 2024 15:10
@Boshen Boshen changed the base branch from 07-01-fix_transformer_typescript_missing_initializer_for_class_constructor_arguments_with_private_and_protected_modifier to main July 1, 2024 15:14
@Boshen Boshen force-pushed the 07-01-fix_transformer_typescript_declare_class_incorrectly_preserved_as_runtime_class branch from fe720b0 to 3df5be5 Compare July 1, 2024 15:57
@Boshen Boshen force-pushed the 07-01-fix_transformer_typescript_declare_class_incorrectly_preserved_as_runtime_class branch from 3df5be5 to bdee156 Compare July 1, 2024 16:04
@graphite-app graphite-app bot merged commit bdee156 into main Jul 1, 2024
25 checks passed
@graphite-app graphite-app bot deleted the 07-01-fix_transformer_typescript_declare_class_incorrectly_preserved_as_runtime_class branch July 1, 2024 16:09
@github-actions github-actions bot mentioned this pull request Jul 2, 2024
Merged
Boshen added a commit that referenced this pull request Jul 2, 2024
@github-actions @Boshen
Release crates v0.16.3 (#4013)
e2c9015 
## [0.16.3] - 2024-07-02

### Features

- b257d53 linter: Support report
`@typescript-eslint/consistent-type-imports` (#3895) (mysteryven)

### Bug Fixes

- 23038ad codegen: Print `TSFunctionType` inside `TSTypeAssertion`
(#3999) (Boshen)
- d995f94 semantic: Resolve reference incorrectly when a parameter
references a parameter that hasn't been defined yet (#4004) (Dunqing)
- bdee156 transformer/typescript: `declare class` incorrectly preserved
as runtime class (#3997) (Dunqing)
- a50ce3d transformer/typescript: Missing initializer for class
constructor arguments with `private` and `protected` modifier (#3996)
(Dunqing)

### Refactor

- 0fe22a8 ast: Reorder fields to reflect their visit order. (#3994)
(rzvxa)
- d0eac46 parser: Use function instead of trait to parse normal lists
(#4003) (Boshen)

Co-authored-by: Boshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

transformer: declare class incorrectly preserved as runtime class
2 participants
@Dunqing @Boshen