Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codegen): print TSFunctionType inside TSTypeAssertion #3999

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Jul 1, 2024

No description provided.

@github-actions github-actions bot added the A-codegen Area - Code Generation label Jul 1, 2024
Copy link
Member Author

Boshen commented Jul 1, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Boshen and the rest of your teammates on Graphite Graphite

Copy link

graphite-app bot commented Jul 1, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@Boshen Boshen force-pushed the 07-01-fix_codegen_print_tsfunctiontype_inside_tstypeassertion_ branch from 3335b1a to 40e9ae2 Compare July 1, 2024 14:40
@Boshen Boshen force-pushed the 07-01-fix_codegen_print_tsfunctiontype_inside_tstypeassertion_ branch from 40e9ae2 to 23038ad Compare July 1, 2024 14:44
Copy link

codspeed-hq bot commented Jul 1, 2024

CodSpeed Performance Report

Merging #3999 will not alter performance

Comparing 07-01-fix_codegen_print_tsfunctiontype_inside_tstypeassertion_ (23038ad) with main (0b56d50)

Summary

✅ 28 untouched benchmarks

Copy link

graphite-app bot commented Jul 1, 2024

Merge activity

@graphite-app graphite-app bot merged commit 23038ad into main Jul 1, 2024
26 checks passed
@graphite-app graphite-app bot deleted the 07-01-fix_codegen_print_tsfunctiontype_inside_tstypeassertion_ branch July 1, 2024 14:51
@github-actions github-actions bot mentioned this pull request Jul 2, 2024
Boshen added a commit that referenced this pull request Jul 2, 2024
## [0.16.3] - 2024-07-02

### Features

- b257d53 linter: Support report
`@typescript-eslint/consistent-type-imports` (#3895) (mysteryven)

### Bug Fixes

- 23038ad codegen: Print `TSFunctionType` inside `TSTypeAssertion`
(#3999) (Boshen)
- d995f94 semantic: Resolve reference incorrectly when a parameter
references a parameter that hasn't been defined yet (#4004) (Dunqing)
- bdee156 transformer/typescript: `declare class` incorrectly preserved
as runtime class (#3997) (Dunqing)
- a50ce3d transformer/typescript: Missing initializer for class
constructor arguments with `private` and `protected` modifier (#3996)
(Dunqing)

### Refactor

- 0fe22a8 ast: Reorder fields to reflect their visit order. (#3994)
(rzvxa)
- d0eac46 parser: Use function instead of trait to parse normal lists
(#4003) (Boshen)

Co-authored-by: Boshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-codegen Area - Code Generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant