feat(linter): add jsx support for only-used-in-recursion #7120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
no-yan
commented
Nov 4, 2024
no-yan
changed the title
CodSpeed Performance ReportMerging #7120 will not alter performanceComparing Summary
|
no-yan
force-pushed
the
feat/support-jsx-in-only-recursion
branch
from
ff8289f to
9bbc8fd
Compare
camc314
reviewed
Nov 4, 2024
camc314
reviewed
Nov 4, 2024
camc314
reviewed
Nov 4, 2024
camc314
reviewed
Nov 4, 2024
camc314
reviewed
Nov 4, 2024
|
This looks good to me i think we can re-use a few exising fns that are already |
|
@camc314 Thank you for the review. I’ve made the suggested changes. I'll rebase fix-up commit after this PR gets approval. |
|
I went ahead and sent an explicit review request, but no rush—take your time! :) |
camc314
approved these changes
Nov 5, 2024
no-yan
force-pushed
the
feat/support-jsx-in-only-recursion
branch
from
14aa74c to
90791de
Compare
no-yan
force-pushed
the
feat/support-jsx-in-only-recursion
branch
from
90791de to
23a0533
Compare
This comment was marked as resolved.
This comment was marked as resolved.
no-yan
force-pushed
the
feat/support-jsx-in-only-recursion
branch
from
23a0533 to
14aa74c
Compare
no-yan
force-pushed
the
feat/support-jsx-in-only-recursion
branch
from
14aa74c to
f791c81
Compare
github-actions
bot
added
A-semantic
no-yan
force-pushed
the
feat/support-jsx-in-only-recursion
branch
from
f791c81 to
bb2dabf
Compare
camc314
approved these changes
Nov 5, 2024
camchenry
approved these changes
Nov 7, 2024
Co-authored-by: Cam McHenry <[email protected]>
Co-authored-by: Cam McHenry <[email protected]>
camchenry
approved these changes
Nov 9, 2024
no-yan
force-pushed
the
feat/support-jsx-in-only-recursion
branch
from
aa4878c to
c42d5ed
Compare
Boshen
added a commit
that referenced
this pull request
Nov 9, 2024
## [0.11.1] - 2024-11-09 ### Features - 4dd9b60 editor/vscode: Replace existing output channel and trace output channel with a single LogOutputChannel (#7196) (Nicholas Rayburn) - 1fcd709 linter: Add jsx support for only-used-in-recursion (#7120) (no-yan) - 4d577cf linter: Add `import/first` rule (#7180) (Dmitry Zakharov) - 9b8973f linter: Add `import/unambiguous` rule (#7187) (Dmitry Zakharov) - 5ab1ff6 linter: Implement @typescript-eslint/no-unsafe-function-type (#6989) (Orenbek) ### Bug Fixes - eea8879 editor/vscode: Update language client id to fix the resolution of the oxc.trace.server setting (#7181) (Nicholas Rayburn) - b73cfd9 linter: Fix `is_method_call` with parentheses and chain expression (#7095) (tbashiyy) ### Refactor - 8c0a362 linter: Use `ctx.source_range(comment.content_span())` API (#7155) (Boshen) - c5485ae semantic: Add `ancestor_kinds` iterator function (#7217) (camchenry) - abf1602 semantic: Rename `iter_parents` to `ancestors` (#7216) (camchenry) - 42171eb semantic: Rename `ancestors` to `ancestor_ids` (#7215) (camchenry) Co-authored-by: Boshen <[email protected]>
|
@no-yan great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #5530
This PR adds support for handling recursive JSX components, allowing detect functions like the one below:
Some logic is duplicated with the non-JSX case. But the refactor will be complicated and affects over-all, so we can make it in another PR.
cc: @DonIsaac @camc314