Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(linter): use ctx.source_range(comment.content_span()) API #7155

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Nov 6, 2024

No description provided.

Copy link

graphite-app bot commented Nov 6, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@Boshen Boshen changed the base branch from 11-06-feat_ast_change_comment.span_to_real_position_that_contain___and___ to graphite-base/7155 November 6, 2024 05:10
Copy link
Member Author

Boshen commented Nov 6, 2024

@github-actions github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Nov 6, 2024
Copy link

graphite-app bot commented Nov 6, 2024

Merge activity

  • Nov 6, 12:15 AM EST: A user added this pull request to the Graphite merge queue.
  • Nov 6, 12:17 AM EST: The Graphite merge queue couldn't merge this PR because it had conflicts with the trunk branch.
  • Nov 6, 1:15 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 6, 1:16 AM EST: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
  • Nov 6, 1:30 AM EST: A user merged this pull request with the Graphite merge queue.

@graphite-app graphite-app bot changed the base branch from graphite-base/7155 to main November 6, 2024 05:16
@github-actions github-actions bot added A-parser Area - Parser A-semantic Area - Semantic A-ast Area - AST A-transformer Area - Transformer / Transpiler A-codegen Area - Code Generation A-prettier Area - Prettier A-isolated-declarations Isolated Declarations labels Nov 6, 2024
Copy link

codspeed-hq bot commented Nov 6, 2024

CodSpeed Performance Report

Merging #7155 will not alter performance

Comparing 11-06-refactor_linter_use_ctx.source_range_comment.content_span_api (8c0a362) with main (b2a888d)

Summary

✅ 30 untouched benchmarks

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Nov 6, 2024
@Boshen Boshen force-pushed the 11-06-refactor_linter_use_ctx.source_range_comment.content_span_api branch 2 times, most recently from 7257972 to 358b012 Compare November 6, 2024 06:17
@Boshen Boshen force-pushed the 11-06-refactor_linter_use_ctx.source_range_comment.content_span_api branch from 358b012 to 8c0a362 Compare November 6, 2024 06:25
@graphite-app graphite-app bot merged commit 8c0a362 into main Nov 6, 2024
26 checks passed
@graphite-app graphite-app bot deleted the 11-06-refactor_linter_use_ctx.source_range_comment.content_span_api branch November 6, 2024 06:30
@oxc-bot oxc-bot mentioned this pull request Nov 9, 2024
Boshen added a commit that referenced this pull request Nov 9, 2024
## [0.11.1] - 2024-11-09

### Features

- 4dd9b60 editor/vscode: Replace existing output channel and trace
output channel with a single LogOutputChannel (#7196) (Nicholas Rayburn)
- 1fcd709 linter: Add jsx support for only-used-in-recursion (#7120)
(no-yan)
- 4d577cf linter: Add `import/first` rule (#7180) (Dmitry Zakharov)
- 9b8973f linter: Add `import/unambiguous` rule (#7187) (Dmitry
Zakharov)
- 5ab1ff6 linter: Implement @typescript-eslint/no-unsafe-function-type
(#6989) (Orenbek)

### Bug Fixes

- eea8879 editor/vscode: Update language client id to fix the resolution
of the oxc.trace.server setting (#7181) (Nicholas Rayburn)
- b73cfd9 linter: Fix `is_method_call` with parentheses and chain
expression (#7095) (tbashiyy)

### Refactor

- 8c0a362 linter: Use `ctx.source_range(comment.content_span())` API
(#7155) (Boshen)
- c5485ae semantic: Add `ancestor_kinds` iterator function (#7217)
(camchenry)
- abf1602 semantic: Rename `iter_parents` to `ancestors` (#7216)
(camchenry)
- 42171eb semantic: Rename `ancestors` to `ancestor_ids` (#7215)
(camchenry)

Co-authored-by: Boshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-ast Area - AST A-codegen Area - Code Generation A-isolated-declarations Isolated Declarations A-linter Area - Linter A-parser Area - Parser A-prettier Area - Prettier A-semantic Area - Semantic A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant