forked from signalapp/Signal-Android
-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SES-1486] Short voice message fix #1523
Merged
AL-Session
merged 31 commits into
oxen-io:dev
from
AL-Session:SES-1486_ShortVoiceMessageFix
Jul 3, 2024
Merged
[SES-1486] Short voice message fix #1523
AL-Session
merged 31 commits into
oxen-io:dev
from
AL-Session:SES-1486_ShortVoiceMessageFix
Jul 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ast if locked to record quickly
app/src/main/java/org/thoughtcrime/securesms/audio/AudioRecorder.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/thoughtcrime/securesms/conversation/v2/ConversationActivityV2.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/thoughtcrime/securesms/conversation/v2/ConversationActivityV2.kt
Show resolved
Hide resolved
app/src/main/java/org/thoughtcrime/securesms/conversation/v2/ConversationActivityV2.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/thoughtcrime/securesms/conversation/v2/ConversationActivityV2.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/thoughtcrime/securesms/conversation/v2/ConversationActivityV2.kt
Outdated
Show resolved
Hide resolved
ThomasSession
approved these changes
Jun 25, 2024
simophin
reviewed
Jun 26, 2024
app/src/main/java/org/thoughtcrime/securesms/conversation/v2/input_bar/InputBar.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/thoughtcrime/securesms/conversation/v2/input_bar/InputBarRecordingView.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/thoughtcrime/securesms/conversation/v2/ConversationActivityV2.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/thoughtcrime/securesms/conversation/v2/ConversationActivityV2.kt
Outdated
Show resolved
Hide resolved
bemusementpark
approved these changes
Jun 26, 2024
simophin
approved these changes
Jun 26, 2024
app/src/main/java/org/thoughtcrime/securesms/conversation/v2/input_bar/InputBar.kt
Outdated
Show resolved
Hide resolved
…oast string following discussion with Lucy
…en sending a voice message - also tweak the locked Cancel button size to prevent text entry when locked to voice recording
app/src/main/java/org/thoughtcrime/securesms/conversation/v2/ConversationActivityV2.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/thoughtcrime/securesms/conversation/v2/ConversationActivityV2.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/thoughtcrime/securesms/webrtc/NetworkChangeReceiver.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/thoughtcrime/securesms/webrtc/NetworkChangeReceiver.kt
Outdated
Show resolved
Hide resolved
ThomasSession
approved these changes
Jul 3, 2024
…orm the user (as per Rebecca / Kee convo)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Fixes oxen-io/session-android#1234
syntaxDescription
Users could sent very short (sub 1-second) voice messages - which is of little use & likely undesirable. This PR prevents sending such short voice messages and displays a toast using a string from the Strings project to inform the user that they should press and hold the microphone button to record voice messages.
Due to the fact that the user can manipulate the UI faster than we can set-up and tear-down the audio recording mechanism there is some state juggling going on to keep track of what's happening internally. From my own testing, the mechanism in this PR is robust against button mashing and multi-finger weirdness.
This PR fixes the following issue: https://github.com/oxen-io/session-android-temp/issues/24
To test you might try to:
##Note
Following discussion w/ Rebecca / Kee the code has been adjusted to merely log any network connectivity issues for the time being rather than inform the user. This will be adjusted again when SES-2319 has been performed.