Code

[SES-1486] Short voice message fix#1523

Code

Merged

AL-Session merged 31 commits intooxen-io:devoxen-io/session-android:devfrom AL-Session:SES-1486_ShortVoiceMessageFixCopy head branch name to clipboardJul 3, 2024

+430-207

Commits

Commits on Jun 25, 2024

• Initial working push with debug comments

  alansley

  committed
  3cdd383

  Copy full SHA for 3cdd383

• Fixes signalapp#1522

  alansley

  committed
  def1265

  Copy full SHA for def1265

• Cleanup, prevent multi-pointer recording, and don't show short msg toast if locked to record quickly

  alansley

  committed
  c15a8ee

  Copy full SHA for c15a8ee

• Adjusted comment phrasing

  alansley

  committed
  d9e1f73

  Copy full SHA for d9e1f73

• Fix comment phrasing

  alansley

  committed
  d5339b7

  Copy full SHA for d5339b7

• Fixed inadvertant short voice message toast on exit conversation activity

  alansley

  committed
  6bb760f

  Copy full SHA for 6bb760f

• Comment adjustment

  alansley

  committed
  9e6c6af

  Copy full SHA for 9e6c6af

• Comment phrasing

  alansley

  committed
  753b49c

  Copy full SHA for 753b49c

• Adjusted AudioRecorder.startRecording to take a callback function rather than the InputBar

  alansley

  committed
  939694d

  Copy full SHA for 939694d

• Performed Thomas' PR feedback

  alansley

  committed
  bd3655b

  Copy full SHA for bd3655b

• Move comment to more relevant place

  alansley

  committed
  d8799c9

  Copy full SHA for d8799c9

• Removed unused / leftover callback definition

  alansley

  committed
  5d8fe27

  Copy full SHA for 5d8fe27

• Removed all redundant null checks after asserting binding is not null

  alansley

  committed
  5858688

  Copy full SHA for 5858688

• Removed remaining not-null assertions & added some logged feedback to fail states

  alansley

  committed
  880148f

  Copy full SHA for 880148f

Commits on Jun 26, 2024

• Addressed PR feedback

  alansley

  committed
  bce6526

  Copy full SHA for bce6526

• Implemented additional PR feedback

  alansley

  committed
  e5371c5

  Copy full SHA for e5371c5

• Merge branch 'dev' into SES-1486_ShortVoiceMessageFix

  alansley

  committed
  ae52e54

  Copy full SHA for ae52e54

Commits on Jun 30, 2024

• Merge branch 'dev' into SES-1486_ShortVoiceMessageFix

  AL-Session

  committed
  1c054b8

  Copy full SHA for 1c054b8

• Adjusted InputBar property visibility as per PR feedback & adjusted Toast string following discussion with Lucy

  AL-Session

  committed
  bc13d20

  Copy full SHA for bc13d20

Commits on Jul 1, 2024

• Minor adjustment to inform user if we see an obvious network issue when sending a voice message - also tweak the locked Cancel button size to prevent text entry when locked to voice recording

  AL-Session

  committed
  6f0277b

  Copy full SHA for 6f0277b

Commits on Jul 2, 2024

• Merge dev

  alansley

  committed
  25d6982

  Copy full SHA for 25d6982

• Adjust comment phrasing following further testing

  alansley

  committed
  5d9c242

  Copy full SHA for 5d9c242

• Merge dev

  alansley

  committed
  f2267e9

  Copy full SHA for f2267e9

• Added TODO comments to replace hard-coded string in toasts

  alansley

  committed
  849a8f1

  Copy full SHA for 849a8f1

Commits on Jul 3, 2024

• Addressed Thomas PR feedback suggestion

  alansley

  committed
  fea66bc

  Copy full SHA for fea66bc

• Addressed another feedback suggestion

  alansley

  committed
  e83b70c

  Copy full SHA for e83b70c

• Adjustment to continue informing user of network / node path issues

  alansley

  committed
  bd9fdc7

  Copy full SHA for bd9fdc7

• Improved & moved network check method

  alansley

  committed
  50d3857

  Copy full SHA for 50d3857

• Corrected ticket number into TODO comments

  alansley

  committed
  4ecda43

  Copy full SHA for 4ecda43

• Addressed Andy PR feedback

  alansley

  committed
  05e8fd8

  Copy full SHA for 05e8fd8

• Adjust network connectivity checks to just log issues rather than inform the user (as per Rebecca / Kee convo)

  alansley

  committed
  af55ae7

  Copy full SHA for af55ae7