forked from signalapp/Signal-Android
-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/1.19.2 #1643
Merged
Merged
Release/1.19.2 #1643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release/1.18.5
Bumping version for 1.18.6
Fix leak in Response#body
[SES-2441] Fix longpress message fails
Co-authored-by: fanchao <[email protected]>
…intent-permission Adding back the fullscreen intent permission
Removing the snodes version patch
* Fixed onion request crashes * Use kotlin.Result instead --------- Co-authored-by: fanchao <[email protected]>
…gService.java Co-authored-by: Andrew <[email protected]>
…gService.java Co-authored-by: Andrew <[email protected]>
…lService.kt Co-authored-by: Andrew <[email protected]>
Feature/service clean up
Optimise SnodeAPI and Add Snode.Version and tests
Merge/1.19.0
# Conflicts: # app/build.gradle # app/src/main/java/org/thoughtcrime/securesms/calls/WebRtcCallActivity.kt # app/src/main/java/org/thoughtcrime/securesms/components/AvatarImageView.java # gradle.properties
Bring Release/1.19.1 to dev
* Removing unrequired APi checks * Bumping min sdk to 26 and further cleaning version checks * More clean ups * Removed unused class
* Removing unrequired APi checks * Bumping min sdk to 26 and further cleaning version checks * More clean ups * Removed unused class * Clean up * Clean up * Clean up * Clean up * Clean up * Clean up * Clean up * Clean up
* [SES-2551] capitalising sentences in convos * [SES-2555] Add bg to image loading * Using Robolectric to fix the tests
We need to rethink the UI tests if we do indeed want to use them as they are not tied to the existing flow anymore
This reverts commit 9919f71. Co-authored-by: fanchao <[email protected]>
* Replaced MLKit with ZXing for QR code scanning * Adjusted some comment spacing * Adjusted some comment phrasing * Renamed MaybeScanQrCode to QRScannerScreen & removed double-import of ZXing core + removed ZXing android-integration --------- Co-authored-by: alansley <[email protected]>
Co-authored-by: fanchao <[email protected]>
Co-authored-by: fanchao <[email protected]>
* Avoiding to recall Ipv4Int on every loop * Avoiding memory allocation since this is used in laarge sets * Further improvements and updated the memory allocation avoiding code * PR feedback
Co-authored-by: fanchao <[email protected]>
AL-Session
approved these changes
Aug 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - but that being said, this is such a large PR I think we have to trust in the separate PRs comprising this to be confident in it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging 1.19.2