Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOAPPX-314] Fix wrong alignment of content in the Alert component #282

Merged
merged 3 commits into from
Jun 7, 2024

Conversation

dmnplb
Copy link
Collaborator

@dmnplb dmnplb commented Jun 7, 2024

Short description

This PR fixes incorrect alignment of content in the Alert component. Unfortunately, we don't have specific style properties to properly manage the text blocks in React Native (like text-box-trim for web), so I added manual adjustments via negative margins.

List of changes proposed in this pull request

  • Add negative margins to fix the wrong alignment

Preview

Before After
Simulator Screenshot - iPhone 15 Pro - 2024-06-07 at 10 09 11 Simulator Screenshot - iPhone 15 Pro - 2024-06-07 at 11 51 03

Details


How to test

  1. Launch the example app
  2. Go to the Alert screen

@dmnplb dmnplb requested review from a team as code owners June 7, 2024 10:15
@dmnplb dmnplb merged commit 0a13c2c into main Jun 7, 2024
6 checks passed
@dmnplb dmnplb deleted the IOAPPX-314-optical-alignment-alert branch June 7, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants