[IOAPPX-330] Allow font scaling to all the typographic styles when experimental DS is on #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR allows font scaling to all typographic styles. This change allows virtually all dynamic sizing on (almost) every DS component.
Important
For testing purposes, font scaling currently only works when experimental DS is enabled.
List of changes proposed in this pull request
allowFontScalingto all the typographic stylesmaxFontSizeMultiplierconstant toIOVisualConstantsAlertcomponent, based on dynamic font scale. Manual fixing has been introduced by this PR:Alertcomponent #282Module…andListItem…componentsPreview
accessible-components-bigger-font-size.mov
How to test