chore(IT Wallet): [SIW-1404] Move CIE/NFC logic to XState (#6508)

ts/features/common/store/reducers/__tests__/__snapshots__/index.test.ts.snap

@@ -121,14 +121,6 @@ exports[`featuresPersistor should match snapshot 1`] = `
         "_tag": "None",
       },
     },
-    "identification": {
-      "isCieSupported": {
-        "kind": "PotNone",
-      },
-      "isNfcEnabled": {
-        "kind": "PotNone",
-      },
-    },
     "issuance": {
       "integrityKeyTag": {
         "_tag": "None",

ts/features/itwallet/common/saga/index.ts

@@ -1,10 +1,8 @@
 import { SagaIterator } from "redux-saga";
-import { call, fork, put } from "typed-redux-saga/macro";
+import { call, fork } from "typed-redux-saga/macro";
 import { watchItwCredentialsSaga } from "../../credentials/saga";
 import { checkCredentialsStatusAttestation } from "../../credentials/saga/checkCredentialsStatusAttestation";
 import { handleWalletCredentialsRehydration } from "../../credentials/saga/handleWalletCredentialsRehydration";
-import { watchItwIdentificationSaga } from "../../identification/saga";
-import { itwCieIsSupported } from "../../identification/store/actions";
 import { watchItwLifecycleSaga } from "../../lifecycle/saga";
 import { checkWalletInstanceStateSaga } from "../../lifecycle/saga/checkWalletInstanceStateSaga";
 
@@ -18,10 +16,6 @@ function* checkWalletInstanceAndCredentialsValiditySaga() {
 export function* watchItwSaga(): SagaIterator {
   yield* fork(checkWalletInstanceAndCredentialsValiditySaga);
   yield* fork(handleWalletCredentialsRehydration);
-  yield* fork(watchItwIdentificationSaga);
   yield* fork(watchItwCredentialsSaga);
   yield* fork(watchItwLifecycleSaga);
-
-  // TODO: [SIW-1404] remove this CIE check and move the logic to xstate
-  yield* put(itwCieIsSupported.request());
 }

ts/features/itwallet/common/store/actions/index.ts

@@ -1,12 +1,10 @@
 import { ItwCredentialsActions } from "../../../credentials/store/actions";
-import { ItwIdentificationActions } from "../../../identification/store/actions";
 import { ItwIssuanceActions } from "../../../issuance/store/actions";
 import { ItwLifecycleActions } from "../../../lifecycle/store/actions";
 import { ItwWalletInstanceActions } from "../../../walletInstance/store/actions";
 import { ItwPreferencesActions } from "./preferences";
 
 export type ItwActions =
-  | ItwIdentificationActions
   | ItwIssuanceActions
   | ItwLifecycleActions
   | ItwCredentialsActions

ts/features/itwallet/common/store/reducers/__tests__/__snapshots__/index.test.ts.snap

@@ -8,14 +8,6 @@ exports[`itWalletReducer should match snapshot 1`] = `
       "_tag": "None",
     },
   },
-  "identification": {
-    "isCieSupported": {
-      "kind": "PotNone",
-    },
-    "isNfcEnabled": {
-      "kind": "PotNone",
-    },
-  },
   "issuance": {
     "integrityKeyTag": {
       "_tag": "None",

ts/features/itwallet/common/store/reducers/index.ts

@@ -14,9 +14,6 @@ import { isDevEnv } from "../../../../../utils/environment";
 import itwCredentialsReducer, {
   ItwCredentialsState
 } from "../../../credentials/store/reducers";
-import identificationReducer, {
-  ItwIdentificationState
-} from "../../../identification/store/reducers";
 import issuanceReducer, {
   ItwIssuanceState
 } from "../../../issuance/store/reducers";
@@ -29,7 +26,6 @@ import wiaReducer, {
 import preferencesReducer, { ItwPreferencesState } from "./preferences";
 
 export type ItWalletState = {
-  identification: ItwIdentificationState;
   issuance: ItwIssuanceState & PersistPartial;
   lifecycle: ItwLifecycleState;
   credentials: ItwCredentialsState & PersistPartial;
@@ -40,7 +36,6 @@ export type ItWalletState = {
 export type PersistedItWalletState = ReturnType<typeof persistedReducer>;
 
 const itwReducer = combineReducers({
-  identification: identificationReducer,
   issuance: issuanceReducer,
   lifecycle: lifecycleReducer,
   credentials: itwCredentialsReducer,

ts/features/itwallet/identification/screens/ItwIdentificationModeSelectionScreen.tsx

@@ -4,24 +4,25 @@ import {
   ModuleNavigation,
   VStack
 } from "@pagopa/io-app-design-system";
-import * as pot from "@pagopa/ts-commons/lib/pot";
 import React, { useCallback, useMemo } from "react";
 import { useFocusEffect } from "@react-navigation/native";
 import I18n from "../../../../i18n";
 import { useIOSelector } from "../../../../store/hooks";
 import { cieFlowForDevServerEnabled } from "../../../cieLogin/utils";
 import { ItwEidIssuanceMachineContext } from "../../machine/provider";
-import { itwIsCieSupportedSelector } from "../store/selectors";
 import {
   trackItWalletIDMethod,
   trackItWalletIDMethodSelected
 } from "../../analytics";
 import { itwDisabledIdentificationMethodsSelector } from "../../../../store/reducers/backendStatus/remoteConfig";
 import { IOScrollViewWithLargeHeader } from "../../../../components/ui/IOScrollViewWithLargeHeader";
+import { isCIEAuthenticationSupportedSelector } from "../../machine/eid/selectors";
 
 export const ItwIdentificationModeSelectionScreen = () => {
   const machineRef = ItwEidIssuanceMachineContext.useActorRef();
-  const isCieSupportedPot = useIOSelector(itwIsCieSupportedSelector);
+  const isCieAuthenticationSupported = ItwEidIssuanceMachineContext.useSelector(
+    isCIEAuthenticationSupportedSelector
+  );
   const disabledIdentificationMethods = useIOSelector(
     itwDisabledIdentificationMethodsSelector
   );
@@ -40,8 +41,8 @@ export const ItwIdentificationModeSelectionScreen = () => {
   );
 
   const isCieSupported = useMemo(
-    () => cieFlowForDevServerEnabled || pot.getOrElse(isCieSupportedPot, false),
-    [isCieSupportedPot]
+    () => cieFlowForDevServerEnabled || isCieAuthenticationSupported,
+    [isCieAuthenticationSupported]
   );
 
   useFocusEffect(trackItWalletIDMethod);

ts/features/itwallet/identification/screens/__tests__/ItwIdentificationModeSelectionScreen.test.tsx

@@ -20,8 +20,8 @@ jest.mock("../../../../../config", () => ({
   itwEnabled: true
 }));
 
-jest.mock("../../../../../store/reducers/cie", () => ({
-  isCieSupportedSelector: () => true
+jest.mock("../../../machine/eid/selectors", () => ({
+  isCIEAuthenticationSupportedSelector: () => true
 }));
 
 describe("ItwIdentificationModeSelectionScreen", () => {

ts/features/itwallet/identification/screens/cie/ItwCiePinScreen.tsx

@@ -6,11 +6,10 @@ import {
   OTPInput,
   VSpacer
 } from "@pagopa/io-app-design-system";
-import * as pot from "@pagopa/ts-commons/lib/pot";
 import { Millisecond } from "@pagopa/ts-commons/lib/units";
 import { useHeaderHeight } from "@react-navigation/elements";
 import { useFocusEffect, useIsFocused } from "@react-navigation/native";
-import React, { useCallback, useEffect, useRef, useState } from "react";
+import React, { useEffect, useRef, useState } from "react";
 import {
   Keyboard,
   KeyboardAvoidingView,
@@ -25,7 +24,7 @@ import { pinPukHelpUrl } from "../../../../../config";
 import { isCieLoginUatEnabledSelector } from "../../../../../features/cieLogin/store/selectors";
 import { useHeaderSecondLevel } from "../../../../../hooks/useHeaderSecondLevel";
 import I18n from "../../../../../i18n";
-import { useIODispatch, useIOSelector } from "../../../../../store/hooks";
+import { useIOSelector } from "../../../../../store/hooks";
 import { setAccessibilityFocus } from "../../../../../utils/accessibility";
 import { useIOBottomSheetAutoresizableModal } from "../../../../../utils/hooks/bottomSheet";
 import { withTrailingPoliceCarLightEmojii } from "../../../../../utils/strings";
@@ -36,8 +35,6 @@ import {
   trackItWalletCiePinInfo
 } from "../../../analytics";
 import { ItwEidIssuanceMachineContext } from "../../../machine/provider";
-import { itwNfcIsEnabled } from "../../store/actions";
-import { itwIsNfcEnabledSelector } from "../../store/selectors";
 
 const CIE_PIN_LENGTH = 8;
 
@@ -64,11 +61,7 @@ const ForgottenPin = () => (
 );
 
 export const ItwCiePinScreen = () => {
-  const dispatch = useIODispatch();
   const useCieUat = useIOSelector(isCieLoginUatEnabledSelector);
-  const isEnabled = useIOSelector(itwIsNfcEnabledSelector);
-  const isNfcEnabled = pot.getOrElse(isEnabled, false);
-
   const machineRef = ItwEidIssuanceMachineContext.useActorRef();
 
   const [pin, setPin] = useState("");
@@ -82,11 +75,6 @@ export const ItwCiePinScreen = () => {
     title: I18n.t("bottomSheets.ciePin.title")
   });
 
-  const requestNfcEnabledCheck = useCallback(
-    () => dispatch(itwNfcIsEnabled.request()),
-    [dispatch]
-  );
-
   useEffect(() => {
     // Reset the pin when the user leaves the screen.
     if (!isFocused) {
@@ -98,8 +86,7 @@ export const ItwCiePinScreen = () => {
     React.useCallback(() => {
       trackItWalletCiePinEnter();
       setAccessibilityFocus(pinPadViewRef, 300 as Millisecond);
-      requestNfcEnabledCheck();
-    }, [requestNfcEnabledCheck])
+    }, [])
   );
 
   useHeaderSecondLevel({
@@ -113,7 +100,7 @@ export const ItwCiePinScreen = () => {
 
     if (value.length === CIE_PIN_LENGTH) {
       Keyboard.dismiss();
-      machineRef.send({ type: "cie-pin-entered", pin: value, isNfcEnabled });
+      machineRef.send({ type: "cie-pin-entered", pin: value });
     }
   };