-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(IT Wallet): [SIW-1404] Move CIE/NFC logic to XState #6508
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6508 +/- ##
==========================================
+ Coverage 48.42% 48.66% +0.23%
==========================================
Files 1488 1570 +82
Lines 31617 32170 +553
Branches 7669 7345 -324
==========================================
+ Hits 15311 15654 +343
- Misses 16238 16464 +226
+ Partials 68 52 -16
... and 1705 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Do you think we can move the CIE capabilities check earlier in the flow? The CIE+PIN button pops in shifting the other buttons: file.mp4 |
You are right. I was testing on iOS where the NFC check is almost instant and I didn't notice that. Addressed here: ed31816, I've also renamed some function/variable for consistency. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Short description
This PR moves the CIE/NFC logic from redux to the XState machine
List of changes proposed in this pull request
How to test
Try to obtain a new wallet using all the available identification methods (SPID, CieId, Cie+pin)