-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: [IOBP-236] IDPay CIE how it works bottom sheet #4982
chore: [IOBP-236] IDPay CIE how it works bottom sheet #4982
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4982 +/- ##
========================================
Coverage 47.47% 47.47%
========================================
Files 1512 1512
Lines 31605 31605
Branches 8022 7917 -105
========================================
Hits 15003 15003
- Misses 16539 16547 +8
+ Partials 63 55 -8 see 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
🎉 All dependencies have been resolved ! |
🎉 All dependencies have been resolved ! |
35dd4bd
to
afa859e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
##⚠️ This PR depends on #4995 and #4982 ## Short description This PR adds the onboarding screen to add CIE as payment method to authorize an IDPay discount initiative transaction. If the idpay code is already onboarded and has a code assigned, it will navigate directly to the thank you page enabling the payment method. If it's the first time and the user still doesn't have a code, it will show a biometric authentication that if it succeed the user will be redirected to the generation code page. ## List of changes proposed in this pull request - Added a new `IdPayCodeOnboardingScreen` content - Added the business logic to do the biometric authentication if the idpay code is not already onboarded; - Added a `WizardScreen` component; - Integrated "How it works?" CTA to open a bottom sheet with more information about it; ## How to test Open the `IdPay Code Playground` from settings and open the `Onboarding` flow. If you click on "Inizia" button, there must be a biometric authentication, if it succeed the navigation should be done directly to a page showing the code generated. ## Preview https://github.com/pagopa/io-app/assets/34343582/57ac282e-4d1a-4bee-98f2-1b4fcc6e184e --------- Co-authored-by: Federico Mastrini <[email protected]>
##⚠️ This PR depends on #4982 and #4994 ## Short description This PR adds an initial page to start the new flow for the discount initiative to choose by which method the user wants to authorize payments. ## List of changes proposed in this pull request - Added a new screen `IdPayDiscountInstrumentsScreen` - Added and setup the use of saga for the configuration folder which actually it handles only those async request of this screen; - Added a new ad-hoc component `IdPayDiscountInstrumentEnrollmentSwitch` that handles the instrument given as input and manage the UI to show based on if the instrument is `IDPAYCODE` or `QRCODE` and the switch that navigates to the onboarding screen - Integrated a bottom sheet to show how to pay with CIE; ## How to test Open a discount initiative details and press on "Metodi di pagamento attivi", then you should be able to enable/disable the CIE as payment method. ## Preview https://github.com/pagopa/io-app/assets/34343582/2625d95e-4aa6-4815-9bcb-2d9a8e91ef36 --------- Co-authored-by: Martino Cesari Tomba <[email protected]> Co-authored-by: Federico Mastrini <[email protected]>
Short description
This PR adds a custom hook
useIdPayInfoCieBottomSheet
designed to display a bottom sheet containing detailed information about how the CIE payment authorization works for a discount initiative.Design reference
FIGMA
List of changes proposed in this pull request
useIdPayInfoCieBottomSheet
with the basicFeatureInfo
components@pagopa/io-app-design-system
libraryHow to test
Actually this is only the definition of the bottomsheet UI, the hook is still not used anywhere but you can try yourself by invoking the
present
method of this custom hook and check the UI.