Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOBP-236] IDPay CIE how it works bottom sheet #4982

Merged
merged 15 commits into from
Sep 27, 2023

Conversation

Hantex9
Copy link
Contributor

@Hantex9 Hantex9 commented Sep 14, 2023

⚠️ This PR depends on pagopa/io-app-design-system#73 and #4990

Short description

This PR adds a custom hook useIdPayInfoCieBottomSheet designed to display a bottom sheet containing detailed information about how the CIE payment authorization works for a discount initiative.

Design reference

FIGMA

List of changes proposed in this pull request

  • Created a new custom hook useIdPayInfoCieBottomSheet with the basic FeatureInfo components
  • Upgraded @pagopa/io-app-design-system library

How to test

Actually this is only the definition of the bottomsheet UI, the hook is still not used anywhere but you can try yourself by invoking the present method of this custom hook and check the UI.

@Hantex9 Hantex9 added IDPay IO-Bonus e pagamenti IO - Bonus e pagamenti labels Sep 14, 2023
@Hantex9 Hantex9 temporarily deployed to dev September 14, 2023 14:07 — with GitHub Actions Inactive
@pagopa-github-bot pagopa-github-bot changed the title feat: [IOBP-236] IDPay CIE how it works bottom sheet chore: [IOBP-236] IDPay CIE how it works bottom sheet Sep 14, 2023
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Sep 14, 2023

Affected stories

  • ⚙️ IOBP-236: Implementazione bottom sheet "Come funziona"
    subtask of
    • IOBP-213: [MVP] IO-IDPay - Pagamento tramite CIE

Generated by 🚫 dangerJS against f17cb71

@Hantex9 Hantex9 temporarily deployed to dev September 14, 2023 14:28 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #4982 (02a6931) into master (1ff4c91) will not change coverage.
The diff coverage is n/a.

❗ Current head 02a6931 differs from pull request most recent head f17cb71. Consider uploading reports for the commit f17cb71 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #4982    +/-   ##
========================================
  Coverage   47.47%   47.47%            
========================================
  Files        1512     1512            
  Lines       31605    31605            
  Branches     8022     7917   -105     
========================================
  Hits        15003    15003            
- Misses      16539    16547     +8     
+ Partials       63       55     -8     

see 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ff4c91...f17cb71. Read the comment docs.

@dpulls
Copy link

dpulls bot commented Sep 15, 2023

🎉 All dependencies have been resolved !

@Hantex9 Hantex9 temporarily deployed to dev September 15, 2023 13:13 — with GitHub Actions Inactive
@Hantex9 Hantex9 temporarily deployed to dev September 18, 2023 07:27 — with GitHub Actions Inactive
@dpulls
Copy link

dpulls bot commented Sep 18, 2023

🎉 All dependencies have been resolved !

@Hantex9 Hantex9 temporarily deployed to dev September 18, 2023 12:42 — with GitHub Actions Inactive
@Hantex9 Hantex9 temporarily deployed to dev September 18, 2023 12:46 — with GitHub Actions Inactive
@Hantex9 Hantex9 temporarily deployed to dev September 18, 2023 14:02 — with GitHub Actions Inactive
@Hantex9 Hantex9 force-pushed the IOBP-236-IDPAY-CIE-how-it-works-bottom-sheet branch from 35dd4bd to afa859e Compare September 18, 2023 15:09
@Hantex9 Hantex9 temporarily deployed to dev September 18, 2023 15:09 — with GitHub Actions Inactive
@Hantex9 Hantex9 temporarily deployed to dev September 19, 2023 08:50 — with GitHub Actions Inactive
@Hantex9 Hantex9 temporarily deployed to dev September 19, 2023 15:10 — with GitHub Actions Inactive
@Hantex9 Hantex9 marked this pull request as ready for review September 20, 2023 08:07
@Hantex9 Hantex9 requested review from thisisjp and a team as code owners September 20, 2023 08:07
@Hantex9 Hantex9 temporarily deployed to dev September 20, 2023 08:22 — with GitHub Actions Inactive
@Hantex9 Hantex9 temporarily deployed to dev September 20, 2023 15:30 — with GitHub Actions Inactive
@Hantex9 Hantex9 temporarily deployed to dev September 20, 2023 15:47 — with GitHub Actions Inactive
@Hantex9 Hantex9 temporarily deployed to dev September 21, 2023 08:34 — with GitHub Actions Inactive
Copy link
Contributor

@mastro993 mastro993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Hantex9 Hantex9 temporarily deployed to dev September 21, 2023 13:17 — with GitHub Actions Inactive
@Hantex9 Hantex9 temporarily deployed to dev September 22, 2023 15:37 — with GitHub Actions Inactive
@Hantex9 Hantex9 temporarily deployed to dev September 26, 2023 10:26 — with GitHub Actions Inactive
@Hantex9 Hantex9 temporarily deployed to dev September 26, 2023 13:40 — with GitHub Actions Inactive
@Hantex9 Hantex9 temporarily deployed to dev September 26, 2023 13:44 — with GitHub Actions Inactive
@Hantex9 Hantex9 temporarily deployed to dev September 27, 2023 07:00 — with GitHub Actions Inactive
@Hantex9 Hantex9 merged commit f5b8115 into master Sep 27, 2023
@Hantex9 Hantex9 deleted the IOBP-236-IDPAY-CIE-how-it-works-bottom-sheet branch September 27, 2023 07:33
Hantex9 added a commit that referenced this pull request Sep 28, 2023
## ⚠️ This PR depends on #4995 and #4982 

## Short description
This PR adds the onboarding screen to add CIE as payment method to
authorize an IDPay discount initiative transaction.
If the idpay code is already onboarded and has a code assigned, it will
navigate directly to the thank you page enabling the payment method. If
it's the first time and the user still doesn't have a code, it will show
a biometric authentication that if it succeed the user will be
redirected to the generation code page.

## List of changes proposed in this pull request
- Added a new `IdPayCodeOnboardingScreen` content
- Added the business logic to do the biometric authentication if the
idpay code is not already onboarded;
- Added a `WizardScreen` component;
- Integrated "How it works?" CTA to open a bottom sheet with more
information about it;

## How to test
Open the `IdPay Code Playground` from settings and open the `Onboarding`
flow. If you click on "Inizia" button, there must be a biometric
authentication, if it succeed the navigation should be done directly to
a page showing the code generated.

## Preview

https://github.com/pagopa/io-app/assets/34343582/57ac282e-4d1a-4bee-98f2-1b4fcc6e184e

---------

Co-authored-by: Federico Mastrini <[email protected]>
Hantex9 added a commit that referenced this pull request Oct 1, 2023
## ⚠️ This PR depends on #4982 and #4994

## Short description
This PR adds an initial page to start the new flow for the discount
initiative to choose by which method the user wants to authorize
payments.

## List of changes proposed in this pull request
- Added a new screen `IdPayDiscountInstrumentsScreen`
- Added and setup the use of saga for the configuration folder which
actually it handles only those async request of this screen;
- Added a new ad-hoc component `IdPayDiscountInstrumentEnrollmentSwitch`
that handles the instrument given as input and manage the UI to show
based on if the instrument is `IDPAYCODE` or `QRCODE` and the switch
that navigates to the onboarding screen
- Integrated a bottom sheet to show how to pay with CIE;

## How to test
Open a discount initiative details and press on "Metodi di pagamento
attivi", then you should be able to enable/disable the CIE as payment
method.

## Preview



https://github.com/pagopa/io-app/assets/34343582/2625d95e-4aa6-4815-9bcb-2d9a8e91ef36

---------

Co-authored-by: Martino Cesari Tomba <[email protected]>
Co-authored-by: Federico Mastrini <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IDPay IO-Bonus e pagamenti IO - Bonus e pagamenti
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants