Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOBP-256] Implements IdPay code flow with redux-saga #4995

Merged
merged 28 commits into from
Sep 28, 2023

Conversation

mastro993
Copy link
Contributor

@mastro993 mastro993 commented Sep 19, 2023

⚠️ Depends on #4994

Short description

This PR implements the IdPay code flow with-redux saga

RocketSim_Recording_iPhone_13_2023-09-21_17.16.15.mp4

List of changes proposed in this pull request

  • Feature A
  • Feature B

How to test

Describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

@mastro993 mastro993 temporarily deployed to dev September 19, 2023 15:25 — with GitHub Actions Inactive
@pagopa-github-bot pagopa-github-bot changed the title [IOBP-256] Implements IdPay code flow with redux-saga chore: [IOBP-256] Implements IdPay code flow with redux-saga Sep 19, 2023
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Sep 19, 2023

Affected stories

  • ⚙️ IOBP-256: Scaffolding flusso con redux-saga
    subtask of
    • IOBP-213: [MVP] IO-IDPay - Pagamento tramite CIE

Generated by 🚫 dangerJS against 74fc563

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #4995 (a9270b3) into master (71d1df2) will decrease coverage by 0.17%.
Report is 1 commits behind head on master.
The diff coverage is 20.60%.

❗ Current head a9270b3 differs from pull request most recent head 74fc563. Consider uploading reports for the commit 74fc563 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4995      +/-   ##
==========================================
- Coverage   47.44%   47.28%   -0.17%     
==========================================
  Files        1508     1522      +14     
  Lines       31464    31672     +208     
  Branches     7878     7922      +44     
==========================================
+ Hits        14929    14976      +47     
- Misses      16483    16644     +161     
  Partials       52       52              
Files Coverage Δ
ts/features/idpay/code/navigation/routes.ts 100.00% <100.00%> (ø)
ts/features/idpay/code/store/actions/index.ts 100.00% <100.00%> (ø)
ts/features/idpay/common/store/reducers/index.ts 100.00% <ø> (ø)
ts/features/idpay/details/store/actions/index.ts 100.00% <ø> (ø)
ts/features/idpay/details/store/index.ts 74.64% <100.00%> (ø)
ts/features/idpay/payment/xstate/services.ts 77.41% <ø> (ø)
ts/features/idpay/timeline/store/actions/index.ts 100.00% <ø> (ø)
ts/features/idpay/timeline/store/index.ts 100.00% <100.00%> (ø)
ts/features/idpay/wallet/store/actions/index.ts 100.00% <ø> (ø)
ts/features/idpay/wallet/store/reducers/index.ts 70.42% <100.00%> (ø)
... and 16 more

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15a9c93...74fc563. Read the comment docs.

@mastro993 mastro993 temporarily deployed to dev September 20, 2023 10:08 — with GitHub Actions Inactive
@mastro993 mastro993 temporarily deployed to dev September 20, 2023 13:37 — with GitHub Actions Inactive
@mastro993 mastro993 temporarily deployed to dev September 20, 2023 15:00 — with GitHub Actions Inactive
@mastro993 mastro993 temporarily deployed to dev September 20, 2023 17:16 — with GitHub Actions Inactive
@mastro993 mastro993 temporarily deployed to dev September 20, 2023 17:44 — with GitHub Actions Inactive
@mastro993 mastro993 temporarily deployed to dev September 21, 2023 12:18 — with GitHub Actions Inactive
@mastro993 mastro993 temporarily deployed to dev September 21, 2023 13:26 — with GitHub Actions Inactive
@mastro993 mastro993 temporarily deployed to dev September 22, 2023 09:23 — with GitHub Actions Inactive
@mastro993 mastro993 temporarily deployed to dev September 26, 2023 13:49 — with GitHub Actions Inactive
@mastro993 mastro993 temporarily deployed to dev September 26, 2023 14:36 — with GitHub Actions Inactive
@mastro993 mastro993 temporarily deployed to dev September 28, 2023 09:02 — with GitHub Actions Inactive
@mastro993 mastro993 marked this pull request as ready for review September 28, 2023 13:29
@mastro993 mastro993 requested a review from a team as a code owner September 28, 2023 13:29
@forrest57 forrest57 temporarily deployed to dev September 28, 2023 13:32 — with GitHub Actions Inactive
Copy link
Contributor

@Hantex9 Hantex9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpulls
Copy link

dpulls bot commented Sep 28, 2023

🎉 All dependencies have been resolved !

@mastro993 mastro993 temporarily deployed to dev September 28, 2023 13:53 — with GitHub Actions Inactive
@mastro993 mastro993 temporarily deployed to dev September 28, 2023 14:02 — with GitHub Actions Inactive
@mastro993 mastro993 merged commit 4b8ccc9 into master Sep 28, 2023
@mastro993 mastro993 deleted the IOBP-256-idpay-code-redux-saga-scaffolding branch September 28, 2023 14:20
Hantex9 added a commit that referenced this pull request Sep 28, 2023
## ⚠️ This PR depends on #4995 and #4982 

## Short description
This PR adds the onboarding screen to add CIE as payment method to
authorize an IDPay discount initiative transaction.
If the idpay code is already onboarded and has a code assigned, it will
navigate directly to the thank you page enabling the payment method. If
it's the first time and the user still doesn't have a code, it will show
a biometric authentication that if it succeed the user will be
redirected to the generation code page.

## List of changes proposed in this pull request
- Added a new `IdPayCodeOnboardingScreen` content
- Added the business logic to do the biometric authentication if the
idpay code is not already onboarded;
- Added a `WizardScreen` component;
- Integrated "How it works?" CTA to open a bottom sheet with more
information about it;

## How to test
Open the `IdPay Code Playground` from settings and open the `Onboarding`
flow. If you click on "Inizia" button, there must be a biometric
authentication, if it succeed the navigation should be done directly to
a page showing the code generated.

## Preview

https://github.com/pagopa/io-app/assets/34343582/57ac282e-4d1a-4bee-98f2-1b4fcc6e184e

---------

Co-authored-by: Federico Mastrini <[email protected]>
Hantex9 added a commit that referenced this pull request Oct 2, 2023
…5005)

## ⚠️ This PR depends on #4983 and #4995

## Short description
This PR adds a `Banner` inside a discount initiative details if the user
has already a CIE onboarded to his account. The banner is shown from the
first time the user lands in the bonus detail, and remains visible
until:
1. The user closes it via "X" close button
2. The user enables the initiative (either via banner or via toggle
within the relevant section)

## List of changes proposed in this pull request
- Added a new action preferences to dismiss the banner, the state is
persisted on the device based on the initiativeId;
- Added a new component `IdPayCodeCieBanner` where is handled all the
business logic to show or not the banner

## How to test
Open a discount initiative, the first time you open the detail you
should see the banner. If you dismiss it, even restarting the app you
should not see it anymore.

## Preview

https://github.com/pagopa/io-app/assets/34343582/01245e66-b80f-4f72-94f9-5a7b87b37c1c

---------

Co-authored-by: forrest57 <[email protected]>
Co-authored-by: Federico Mastrini <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IDPay IO-Bonus e pagamenti IO - Bonus e pagamenti
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants