-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: [IOBP-256] Implements IdPay code flow with redux-saga #4995
chore: [IOBP-256] Implements IdPay code flow with redux-saga #4995
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4995 +/- ##
==========================================
- Coverage 47.44% 47.28% -0.17%
==========================================
Files 1508 1522 +14
Lines 31464 31672 +208
Branches 7878 7922 +44
==========================================
+ Hits 14929 14976 +47
- Misses 16483 16644 +161
Partials 52 52
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🎉 All dependencies have been resolved ! |
##⚠️ This PR depends on #4995 and #4982 ## Short description This PR adds the onboarding screen to add CIE as payment method to authorize an IDPay discount initiative transaction. If the idpay code is already onboarded and has a code assigned, it will navigate directly to the thank you page enabling the payment method. If it's the first time and the user still doesn't have a code, it will show a biometric authentication that if it succeed the user will be redirected to the generation code page. ## List of changes proposed in this pull request - Added a new `IdPayCodeOnboardingScreen` content - Added the business logic to do the biometric authentication if the idpay code is not already onboarded; - Added a `WizardScreen` component; - Integrated "How it works?" CTA to open a bottom sheet with more information about it; ## How to test Open the `IdPay Code Playground` from settings and open the `Onboarding` flow. If you click on "Inizia" button, there must be a biometric authentication, if it succeed the navigation should be done directly to a page showing the code generated. ## Preview https://github.com/pagopa/io-app/assets/34343582/57ac282e-4d1a-4bee-98f2-1b4fcc6e184e --------- Co-authored-by: Federico Mastrini <[email protected]>
…5005) ##⚠️ This PR depends on #4983 and #4995 ## Short description This PR adds a `Banner` inside a discount initiative details if the user has already a CIE onboarded to his account. The banner is shown from the first time the user lands in the bonus detail, and remains visible until: 1. The user closes it via "X" close button 2. The user enables the initiative (either via banner or via toggle within the relevant section) ## List of changes proposed in this pull request - Added a new action preferences to dismiss the banner, the state is persisted on the device based on the initiativeId; - Added a new component `IdPayCodeCieBanner` where is handled all the business logic to show or not the banner ## How to test Open a discount initiative, the first time you open the detail you should see the banner. If you dismiss it, even restarting the app you should not see it anymore. ## Preview https://github.com/pagopa/io-app/assets/34343582/01245e66-b80f-4f72-94f9-5a7b87b37c1c --------- Co-authored-by: forrest57 <[email protected]> Co-authored-by: Federico Mastrini <[email protected]>
Short description
This PR implements the IdPay code flow with-redux saga
RocketSim_Recording_iPhone_13_2023-09-21_17.16.15.mp4
List of changes proposed in this pull request
How to test
Describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.