-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(IT Wallet): [SIW-1036] Add eID detail screen #5801
Conversation
…-eid-preview-screen
I updated the code to remove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That space separates claims that are not mapped to a section from the other claims. I am not really sure how to handle this case, in the ideal world all claims should be mapped to a section. Moreover, in the mocked credential a few claims are missing or are extra compared to the design. The mapping is configurable, we can adjust it as we start getting the real credentials or we can discuss another approach. |
the |
Warning
This PR depends on #5780
Short description
This PR adds the credential detail screen for the eID. The screen can support other credential types as well, it would just need a bit more fine tuning.
Note
In the detail screen claims are grouped into sections, but this information is not included in the credential itself. To work around this, a mapping claim-section has been hardcoded in app. Claims that can not be assigned to any section are displayed after all the others.
The eID credential used is also a mock.
List of changes proposed in this pull request
RenderPidAssuranceLevel
andRenderReleaserName
into separate components for easier reuseItwPresentationEidDetailScreen
component with related sub-componentsItwCredentialClaim
to support hidden claims and dates with icon and badgeitwClaimsUtils
to handle hardcoded claims configurationsHow to test
Navigate to Profile > IT Wallet > Credential detail (eID). You should be able to see the eID detail screen.
Preview
iOS_eid_detail_screen.mp4
android_eid_detail_screen.mp4