Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(IT Wallet): [SIW-1036] Add eID detail screen #5801

Merged
merged 76 commits into from
Jun 17, 2024

Conversation

gispada
Copy link
Collaborator

@gispada gispada commented May 29, 2024

Warning

This PR depends on #5780

Short description

This PR adds the credential detail screen for the eID. The screen can support other credential types as well, it would just need a bit more fine tuning.

Note

In the detail screen claims are grouped into sections, but this information is not included in the credential itself. To work around this, a mapping claim-section has been hardcoded in app. Claims that can not be assigned to any section are displayed after all the others.
The eID credential used is also a mock.

List of changes proposed in this pull request

  • Extracted RenderPidAssuranceLevel and RenderReleaserName into separate components for easier reuse
  • Added ItwPresentationEidDetailScreen component with related sub-components
  • Modified ItwCredentialClaim to support hidden claims and dates with icon and badge
  • Add utils in itwClaimsUtils to handle hardcoded claims configurations

How to test

Navigate to Profile > IT Wallet > Credential detail (eID). You should be able to see the eID detail screen.

Preview

iOS Android
iOS_eid_detail_screen.mp4
android_eid_detail_screen.mp4

@gispada
Copy link
Collaborator Author

gispada commented Jun 13, 2024

I updated the code to remove BaseScreenComponent and use HeaderSecondLevel with the new props from pagopa/io-app-design-system#285. I also used the new hook useScreenEndMargin for the scroll view paddingBottom.

@LazyAfternoons LazyAfternoons requested a review from hevelius June 14, 2024 09:41
Copy link
Contributor

@hevelius hevelius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this extra space be here?

Simulator Screenshot - iPhone 15 Pro - 2024-06-14 at 12 10 54

@gispada
Copy link
Collaborator Author

gispada commented Jun 14, 2024

Should this extra space be here?

That space separates claims that are not mapped to a section from the other claims. I am not really sure how to handle this case, in the ideal world all claims should be mapped to a section. Moreover, in the mocked credential a few claims are missing or are extra compared to the design.

The mapping is configurable, we can adjust it as we start getting the real credentials or we can discuss another approach.

@hevelius
Copy link
Contributor

Should this extra space be here?

That space separates claims that are not mapped to a section from the other claims. I am not really sure how to handle this case, in the ideal world all claims should be mapped to a section. Moreover, in the mocked credential a few claims are missing or are extra compared to the design.

The mapping is configurable, we can adjust it as we start getting the real credentials or we can discuss another approach.

the VSpacer is always added regardless of whether there was a claims section before or not. I believe a different approach should be used. For the moment, however, I would leave it like this.

@hevelius hevelius merged commit f6e0e19 into master Jun 17, 2024
13 checks passed
@hevelius hevelius deleted the SIW-1036-eID-detail-screen branch June 17, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants