[IOAPPX-318] Add contrast variant and optional backgroundColor prop to HeaderSecondLevel
#285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hevelius
reviewed
Jun 11, 2024
There was a problem hiding this comment.
LGTM. Tested and works as expected. @mastro993 having already encountered this case, what do you think?
|
I don't know if this is expected or not (maybe is just the example), but on Android I see a white header. Registrazione.schermo.2024-06-12.alle.15.00.06.mov |
|
@mastro993 Considering that the blue block is just an ugly block with |
|
@mastro993 Just fixed the example screen on both iOS and Android ✌🏻 |
mastro993
approved these changes
Jun 12, 2024
dmnplb
added a commit
that referenced
this pull request
Jun 18, 2024
## Short description This PR fixes the `HeaderSecondLevel` UI regression, introduced by mistake with the following PR: * #285 The problem ## List of changes proposed in this pull request - Apply the `animatedStyle` in all the conditions ### Preview (Please look at the header's bottom border) | Before | After | |--------|--------| | <video src="https://github.com/pagopa/io-app-design-system/assets/1255491/cafdf95b-b4a4-4b5c-a316-21708a04c758" /> | <video src="https://github.com/pagopa/io-app-design-system/assets/1255491/96dc7c95-e658-4f12-95ff-e4b9efed3565" /> | ## How to test 1. Launch the example app 2. Check out every example that's using `HeaderSecondLevel`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR adds a
contrastvariant (light icons on dark background) and an optionalbackgroundColorprop to set a custom background color when there's a transition between the transparent → solid state.List of changes proposed in this pull request
variantandbackgroundColorpropsPreview
header2ndLevel-customBG.mp4
How to test
HeaderSecondLevel, including the new custom background