-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(Cross): [IOAPPX-445] Replace legacy FooterWithButtons
with a mix of FooterActions
and FooterActionsInline
#6477
Merged
dmnplb
merged 21 commits into
master
from
IOAPPX-445-replace-legacy-footer-with-buttons
Dec 10, 2024
Merged
chore(Cross): [IOAPPX-445] Replace legacy FooterWithButtons
with a mix of FooterActions
and FooterActionsInline
#6477
dmnplb
merged 21 commits into
master
from
IOAPPX-445-replace-legacy-footer-with-buttons
Dec 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmnplb
added
the
Design System
New visual language and reduction of previous UI clutter
label
Dec 2, 2024
pagopa-github-bot
changed the title
[IOAPPX-445] Replace legacy
chore(Cross): [IOAPPX-445] Replace legacy Dec 2, 2024
FooterWithButtons
with a mix of FooterActions
and FooterActionsInline
FooterWithButtons
with a mix of FooterActions
and FooterActionsInline
Affected stories
|
dmnplb
added
the
💀 Dead matter
Graphic assets or chunks of code that are no longer referenced or needed
label
Dec 3, 2024
dmnplb
requested review from
ChrisMattew,
gispada,
freddi301 and
a team
as code owners
December 3, 2024 15:12
LeleDallas
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
B&P seems good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Cross
💀 Dead matter
Graphic assets or chunks of code that are no longer referenced or needed
Design System
New visual language and reduction of previous UI clutter
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR removes the remaining instances of the legacy
FooterWithButtons
(which will soon be removed from theio-app-design-system
package). Depending on the screen, this component has been replaced byFooterActions
(SingleButton
conf) orFooterActionsInline
.List of changes proposed in this pull request
FooterWithButtons
from the following flows: IDPay, Firma con IO, CGNFooterWithButtons
from some screens related to A&IFooterStackButton
andFooterTopShadow
, not used anymoreDocumentViewer
(Firma con IO), because it's a no longer supported combination (Save
is preserved overOpen
).How to test
Randomly check some edited screens to see if everything is OK.