Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Cross): [IOAPPX-445] Replace legacy FooterWithButtons with a mix of FooterActions and FooterActionsInline #6477

Merged
merged 21 commits into from
Dec 10, 2024

Conversation

dmnplb
Copy link
Contributor

@dmnplb dmnplb commented Dec 2, 2024

Short description

This PR removes the remaining instances of the legacy FooterWithButtons (which will soon be removed from the io-app-design-system package). Depending on the screen, this component has been replaced by FooterActions (SingleButton conf) or FooterActionsInline.

List of changes proposed in this pull request

  • Remove legacy FooterWithButtons from the following flows: IDPay, Firma con IO, CGN
  • Remove legacy FooterWithButtons from some screens related to A&I
  • Remove FooterStackButton and FooterTopShadow, not used anymore
  • Replace the three-button combo from DocumentViewer (Firma con IO), because it's a no longer supported combination (Save is preserved over Open).

How to test

Randomly check some edited screens to see if everything is OK.

@dmnplb dmnplb added the Design System New visual language and reduction of previous UI clutter label Dec 2, 2024
@pagopa-github-bot pagopa-github-bot changed the title [IOAPPX-445] Replace legacy FooterWithButtons with a mix of FooterActions and FooterActionsInline chore(Cross): [IOAPPX-445] Replace legacy FooterWithButtons with a mix of FooterActions and FooterActionsInline Dec 2, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Dec 2, 2024

Affected stories

  • ⚙️ IOAPPX-445: Sostituzione del componente legacy FooterWithButtons con FooterActionsInline
    subtask of

Generated by 🚫 dangerJS against 7655ab7

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 22.85714% with 54 lines in your changes missing coverage. Please review.

Project coverage is 48.67%. Comparing base (4f204b4) to head (7655ab7).
Report is 856 commits behind head on master.

Files with missing lines Patch % Lines
...components/MessageAttachment/MessageAttachment.tsx 7.69% 12 Missing ⚠️
...nus/cdc/screens/CdcBonusRequestSelectResidence.tsx 14.28% 6 Missing ⚠️
...figuration/screens/InstrumentsEnrollmentScreen.tsx 0.00% 6 Missing ⚠️
...ption/screens/UnsubscriptionConfirmationScreen.tsx 0.00% 6 Missing ⚠️
...es/bonus/cdc/screens/CdcBonusRequestSelectYear.tsx 0.00% 5 Missing ⚠️
ts/components/screens/GenericErrorComponent.tsx 0.00% 4 Missing ⚠️
...onus/cdc/screens/CdcBonusRequestInformationTos.tsx 0.00% 4 Missing ⚠️
...le/components/services/ManualConfigBottomSheet.tsx 0.00% 4 Missing ⚠️
ts/features/fci/components/DocumentViewer.tsx 0.00% 2 Missing ⚠️
...authentication/cie/CieAuthorizeDataUsageScreen.tsx 0.00% 2 Missing ⚠️
... and 3 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6477      +/-   ##
==========================================
+ Coverage   48.42%   48.67%   +0.24%     
==========================================
  Files        1488     1570      +82     
  Lines       31617    32154     +537     
  Branches     7669     7335     -334     
==========================================
+ Hits        15311    15651     +340     
- Misses      16238    16452     +214     
+ Partials       68       51      -17     
Files with missing lines Coverage Δ
ts/components/TosWebviewErrorComponent.tsx 50.00% <ø> (ø)
ts/components/error/WorkunitGenericFailure.tsx 50.00% <ø> (-33.34%) ⬇️
...ures/bonus/cdc/components/CdcRequirementsError.tsx 100.00% <ø> (ø)
...s/cgn/components/merchants/CgnMerchantsFilters.tsx 2.63% <ø> (-0.15%) ⬇️
...s/cgn/screens/merchants/CgnMerchantsTabsScreen.tsx 33.33% <ø> (-1.97%) ⬇️
...ures/bonus/common/screens/AvailableBonusScreen.tsx 7.69% <ø> (-1.24%) ⬇️
.../features/fci/components/DocumentWithSignature.tsx 47.91% <ø> (ø)
ts/features/fci/hooks/useFciCheckService.tsx 43.47% <100.00%> (ø)
ts/features/fci/hooks/useFciNoSignatureFields.tsx 50.00% <100.00%> (-2.95%) ⬇️
...eatures/fci/screens/valid/FciDataSharingScreen.tsx 70.45% <100.00%> (ø)
... and 26 more

... and 1683 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fd724e...7655ab7. Read the comment docs.

@dmnplb dmnplb added the 💀 Dead matter Graphic assets or chunks of code that are no longer referenced or needed label Dec 3, 2024
@dmnplb dmnplb marked this pull request as ready for review December 3, 2024 15:12
@dmnplb dmnplb requested review from ChrisMattew, gispada, freddi301 and a team as code owners December 3, 2024 15:12
Copy link
Contributor

@LeleDallas LeleDallas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

B&P seems good!

@dmnplb dmnplb merged commit 89bb56a into master Dec 10, 2024
12 checks passed
@dmnplb dmnplb deleted the IOAPPX-445-replace-legacy-footer-with-buttons branch December 10, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cross 💀 Dead matter Graphic assets or chunks of code that are no longer referenced or needed Design System New visual language and reduction of previous UI clutter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants