Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spid-testenv application #21

Merged
merged 10 commits into from
Oct 25, 2021
Merged

spid-testenv application #21

merged 10 commits into from
Oct 25, 2021

Conversation

antonioT90
Copy link
Contributor

List of changes

Motivation and context

integration of spid-testenv mock
copied from https://github.com/pagopa/cgn-onboarding-portal-infra/blob/master/code/spid_testenv.tf trying to use it as an external module

Type of changes

  • Add new resources
  • Update configuration to existing resources
  • Remove existing resources

Env to apply

  • DEV
  • UAT
  • PROD

Does this introduce a change to production resources with possible user impact?

  • Yes, users may be impacted applying this change
  • No

Does this introduce an unwanted change on infrastructure? Check terraform plan execution result

  • Yes
  • No

Other information


If PR is partially applied, why? (reserved to mantainers)

@antonioT90 antonioT90 requested review from pasqualedevita and a team October 15, 2021 19:45
pasqualedevita
pasqualedevita previously approved these changes Oct 21, 2021
# Conflicts:
#	src/core/env/dev/terraform.tfvars
#	src/core/variables.tf
@antonioT90 antonioT90 requested a review from iwoak October 25, 2021 10:07
Copy link
Contributor

@iwoak iwoak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antonioT90 antonioT90 merged commit 6460f00 into main Oct 25, 2021
@antonioT90 antonioT90 deleted the spid-testenv branch October 25, 2021 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants