Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no SERVER_PORT env for hub-spid-login #25

Merged
merged 1 commit into from
Oct 21, 2021

Conversation

antonioT90
Copy link
Contributor

@antonioT90 antonioT90 commented Oct 20, 2021

List of changes

removed SERVER_PORT from hub-spid-login config map

Motivation and context

Type of changes

  • Add new resources
  • Update configuration to existing resources
  • Remove existing resources

Env to apply

  • DEV
  • UAT
  • PROD

Does this introduce a change to production resources with possible user impact?

  • Yes, users may be impacted applying this change
  • No

Does this introduce an unwanted change on infrastructure? Check terraform plan execution result

  • Yes
  • No

Other information


If PR is partially applied, why? (reserved to mantainers)

@antonioT90 antonioT90 requested review from uolter, pasqualedevita and a team October 20, 2021 16:04
@iwoak iwoak requested review from iwoak and removed request for pasqualedevita October 21, 2021 07:20
Copy link
Contributor

@iwoak iwoak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antonioT90 antonioT90 merged commit 9da381f into main Oct 21, 2021
@antonioT90 antonioT90 deleted the hub-spid-login-no-server-port-env branch October 21, 2021 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants