Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hub spid login require jwt between certificate #28

Merged
merged 1 commit into from
Oct 22, 2021
Merged

hub spid login require jwt between certificate #28

merged 1 commit into from
Oct 22, 2021

Conversation

antonioT90
Copy link
Contributor

List of changes

jwt stored in certificates

Motivation and context

required by hub spid login api

Type of changes

  • Add new resources
  • Update configuration to existing resources
  • Remove existing resources

Env to apply

  • DEV
  • UAT
  • PROD

Does this introduce a change to production resources with possible user impact?

  • Yes, users may be impacted applying this change
  • No

Does this introduce an unwanted change on infrastructure? Check terraform plan execution result

  • Yes
  • No

Other information

If PR is partially applied, why? (reserved to mantainers)

@antonioT90 antonioT90 requested a review from a team October 21, 2021 18:54
iwoak
iwoak approved these changes Oct 22, 2021
View reviewed changes
Copy link
Contributor

@iwoak iwoak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antonioT90 antonioT90 merged commit 5789c5f into main Oct 22, 2021
@antonioT90 antonioT90 deleted the jwt-in-certificates branch October 22, 2021 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwoak iwoak iwoak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonioT90 @iwoak