Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix login be #29

Merged
merged 3 commits into from
Oct 25, 2021
Merged

Fix login be #29

merged 3 commits into from
Oct 25, 2021

Conversation

antonioT90
Copy link
Contributor

@antonioT90 antonioT90 commented Oct 22, 2021

List of changes

fixed login config

to apply after PR 21

Motivation and context

Type of changes

  • Add new resources
  • Update configuration to existing resources
  • Remove existing resources

Env to apply

  • DEV
  • UAT
  • PROD

Does this introduce a change to production resources with possible user impact?

  • Yes, users may be impacted applying this change
  • No

Does this introduce an unwanted change on infrastructure? Check terraform plan execution result

  • Yes
  • No

Other information


If PR is partially applied, why? (reserved to mantainers)

@antonioT90 antonioT90 requested review from a team, rodoviti and iwoak October 22, 2021 21:16
Copy link
Contributor

@iwoak iwoak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antonioT90 antonioT90 merged commit 07724c4 into main Oct 25, 2021
@antonioT90 antonioT90 deleted the fix-login-be branch October 25, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants