private blobstorage to store party contracts #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pasqualedevita
requested changes
Oct 28, 2021
added 2 commits
October 29, 2021 09:31
pasqualedevita
requested changes
Nov 2, 2021
src/core/storage.tf
Outdated
| name = replace(format("%s-blobstorage", local.project), "-", "") | ||
| account_kind = "StorageV2" | ||
| account_tier = "Standard" | ||
| account_replication_type = "LRS" |
There was a problem hiding this comment.
since in this storage will be stored contracts I suggest to use RA-GZRS for production env (LRS for dev,uat)
https://docs.microsoft.com/en-us/azure/storage/common/storage-redundancy#durability-and-availability-parameters
There was a problem hiding this comment.
@iwoak how much days should we configure the delete retention period in prod? in other environment it'sok to set 1 day?
added 2 commits
November 4, 2021 11:40
# Conflicts: # src/core/variables.tf
pasqualedevita
approved these changes
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes
private blobstorage to store party contracts
Motivation and context
Type of changes
Env to apply
Does this introduce a change to production resources with possible user impact?
Does this introduce an unwanted change on infrastructure? Check terraform plan execution result
Other information
If PR is partially applied, why? (reserved to mantainers)