Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renamed pdnd services + ingress #35

Merged
merged 4 commits into from
Nov 2, 2021
Merged

Conversation

antonioT90
Copy link
Contributor

List of changes

renamed pdnd services + ingress

Motivation and context

Type of changes

  • Add new resources
  • Update configuration to existing resources
  • Remove existing resources

Env to apply

  • DEV
  • UAT
  • PROD

Does this introduce a change to production resources with possible user impact?

  • Yes, users may be impacted applying this change
  • No

Does this introduce an unwanted change on infrastructure? Check terraform plan execution result

  • Yes
  • No

Other information


If PR is partially applied, why? (reserved to mantainers)

@antonioT90 antonioT90 requested a review from a team October 29, 2021 16:15
Copy link
Member

@pasqualedevita pasqualedevita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check io-infra to have a more clean structure.
for example add to show correct version name in api management (not Original)

api_version           = "v1"

cfr.: https://github.com/pagopa/io-infra/blob/main/src/core/apim_io_backend_v1.tf

@antonioT90 antonioT90 merged commit f7684b1 into main Nov 2, 2021
@antonioT90 antonioT90 deleted the fix-interop-party-names branch November 2, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants