Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging appgw #57

Merged
merged 2 commits into from
Nov 23, 2021
Merged

Logging appgw #57

merged 2 commits into from
Nov 23, 2021

Conversation

antonioT90
Copy link
Contributor

List of changes

logging appgw

Motivation and context

Type of changes

  • Add new resources
  • Update configuration to existing resources
  • Remove existing resources

Env to apply

  • DEV
  • UAT
  • PROD

Does this introduce a change to production resources with possible user impact?

  • Yes, users may be impacted applying this change
  • No

Does this introduce an unwanted change on infrastructure? Check terraform plan execution result

  • Yes
  • No

Other information


If PR is partially applied, why? (reserved to mantainers)

@antonioT90 antonioT90 requested a review from a team November 23, 2021 15:25
iwoak
iwoak previously approved these changes Nov 23, 2021
Copy link
Contributor

@iwoak iwoak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iwoak iwoak self-requested a review November 23, 2021 20:02
@antonioT90 antonioT90 merged commit 832888c into main Nov 23, 2021
@antonioT90 antonioT90 deleted the logging-appgw branch November 23, 2021 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants