Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

appgateway review #68

Merged
merged 3 commits into from
Dec 9, 2021
Merged

appgateway review #68

merged 3 commits into from
Dec 9, 2021

Conversation

pasqualedevita
Copy link
Member

@pasqualedevita pasqualedevita commented Dec 9, 2021 •
edited
Loading

List of changes

  • upgrade app gateway to v2.0.9
  • add app gateway alerts
  • fix app gateway access to keyvault
  • app gateway standard sku for dev/uat
  • format
  • fix terraform state (plan diff for law workspace id)

Motivation and context

app gateway revirew

Type of changes

  • Add new resources
  • Update configuration to existing resources
  • Remove existing resources

Env to apply

  • DEV
  • UAT
  • PROD

Does this introduce a change to production resources with possible user impact?

  • Yes, users may be impacted applying this change
  • No

Does this introduce an unwanted change on infrastructure? Check terraform plan execution result

  • Yes
  • No

Other information

If PR is partially applied, why? (reserved to mantainers)

@pasqualedevita pasqualedevita requested a review from a team December 9, 2021 17:04
@pasqualedevita pasqualedevita merged commit 1b49e4f into main Dec 9, 2021
@pasqualedevita pasqualedevita deleted the fix-appgateway branch December 9, 2021 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonioT90 antonioT90 Awaiting requested review from antonioT90

@diegolagospagopa diegolagospagopa Awaiting requested review from diegolagospagopa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pasqualedevita