Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SELC-284] Remove unused data from spid info #69

Merged
merged 3 commits into from
Dec 9, 2021

Conversation

iwoak
Copy link
Contributor

@iwoak iwoak commented Dec 9, 2021

List of changes

Change the variable SPID_ATTRIBUTES used by hub-spid-login-ms to minimize spid assertion requested to IDP.

Motivation and context

Request only used information about user to IDP through spid

Type of changes

  • Add new resources
  • [x ] Update configuration to existing resources
  • Remove existing resources

Env to apply

  • DEV
  • UAT
  • PROD

Does this introduce a change to production resources with possible user impact?

  • Yes, users may be impacted applying this change
  • No

Does this introduce an unwanted change on infrastructure? Check terraform plan execution result

  • Yes
  • No

Other information


If PR is partially applied, why? (reserved to mantainers)

@iwoak iwoak requested a review from a team December 9, 2021 17:14
@pasqualedevita pasqualedevita merged commit 119edcc into main Dec 9, 2021
@pasqualedevita pasqualedevita deleted the SELC-284-lower-spid-assertion-requested branch December 9, 2021 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants