Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SELC-285] Kid secrets #72

Merged
merged 9 commits into from
Dec 10, 2021
Merged

[SELC-285] Kid secrets #72

merged 9 commits into from
Dec 10, 2021

Conversation

antonioT90
Copy link
Contributor

List of changes

KID in jwks calculated as md5 and stored as secret in keyvault and configMap in k8s

Motivation and context

Type of changes

  • Add new resources
  • Update configuration to existing resources
  • Remove existing resources

Env to apply

  • DEV
  • UAT
  • PROD

Does this introduce a change to production resources with possible user impact?

  • Yes, users may be impacted applying this change
  • No

Does this introduce an unwanted change on infrastructure? Check terraform plan execution result

  • Yes
  • No

Other information


If PR is partially applied, why? (reserved to mantainers)

@antonioT90 antonioT90 requested a review from a team December 9, 2021 17:59
iwoak
iwoak previously approved these changes Dec 9, 2021
Copy link
Contributor

@iwoak iwoak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look great to me 👍 @antonioT90 :)

@iwoak iwoak changed the title Kid secrets [SELC-285] Kid secrets Dec 10, 2021
@iwoak iwoak self-requested a review December 10, 2021 09:21
@antonioT90 antonioT90 merged commit a56aad0 into main Dec 10, 2021
@antonioT90 antonioT90 deleted the kid-secrets branch December 10, 2021 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants