Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keyvault review #91

Merged
merged 2 commits into from
Dec 16, 2021
Merged

keyvault review #91

merged 2 commits into from
Dec 16, 2021

Conversation

pasqualedevita
Copy link
Member

@pasqualedevita pasqualedevita commented Dec 15, 2021

List of changes

  • send keyvault logs to security

Motivation and context

compliance

Type of changes

  • Add new resources
  • Update configuration to existing resources
  • Remove existing resources

Env to apply

  • DEV
  • UAT
  • PROD

Does this introduce a change to production resources with possible user impact?

  • Yes, users may be impacted applying this change
  • No

Does this introduce an unwanted change on infrastructure? Check terraform plan execution result

  • Yes
  • No

Other information


If PR is partially applied, why? (reserved to mantainers)

Copy link
Contributor

@iwoak iwoak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diegolagospagopa diegolagospagopa merged commit 8599a20 into main Dec 16, 2021
@diegolagospagopa diegolagospagopa deleted the keyvault-review branch December 16, 2021 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants