Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extended request timeout to 60 seconds on gateway #92

Merged
merged 3 commits into from
Dec 16, 2021

Conversation

antonioT90
Copy link
Contributor

List of changes

extended request timeout to 60 seconds

Motivation and context

Type of changes

  • Add new resources
  • Update configuration to existing resources
  • Remove existing resources

Env to apply

  • DEV
  • UAT
  • PROD

Does this introduce a change to production resources with possible user impact?

  • Yes, users may be impacted applying this change
  • No

Does this introduce an unwanted change on infrastructure? Check terraform plan execution result

  • Yes
  • No

Other information


If PR is partially applied, why? (reserved to mantainers)

@antonioT90 antonioT90 requested a review from a team December 15, 2021 18:44
Copy link
Member

@pasqualedevita pasqualedevita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 60 seconds?

@antonioT90
Copy link
Contributor Author

Why 60 seconds?

this timeout has to allow also the upload of documents, moreover the first invocation of pdnd services, using lazy logic to load certain configuration, requires more than 10 seconds, we choose to extend it in order to allow a larger timeout.

Do you suggest us to reduce it?

@iwoak

@pasqualedevita
Copy link
Member

Ok for download and upload apis... All others we need to be responsive and stay under 1 or 2 seconds :)

@diegolagospagopa diegolagospagopa merged commit 27d5f3f into main Dec 16, 2021
@diegolagospagopa diegolagospagopa deleted the extended-timeout branch December 16, 2021 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants