This repository has been archived by the owner on Sep 19, 2024. It is now read-only.
Ref #612: Use detachedConfiguration() to cleanly resolve old API artifact with Gradle 8.2+ #663
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
With Gradle 8.2+, revapi plugin doesn't detect any ABI/API breaks.
The reason is because it doesn't resolve the right artifacts for the old API: it always compares new API with new API.
The old API artifact is actually resolved using the project version (so the SNAPSHOT version) instead of the old version defined.
After this PR
Using
detachedConfiguration()
in theOldApiConfigurations
allow to not get the project default artifact but actually the old API one (correct).Possible downsides?
This change works with any Gradle version. The only downside with
detachedConfiguration()
is when using--configuration-cache
as detached configurations can't be cached.This closes #612