Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecation warning with Ruby 3.1 #207

Closed
GoktugOzturk opened this issue Mar 22, 2022 · 2 comments · Fixed by #208
Closed

deprecation warning with Ruby 3.1 #207

GoktugOzturk opened this issue Mar 22, 2022 · 2 comments · Fixed by #208

Comments

@GoktugOzturk
Copy link
Contributor

GoktugOzturk commented Mar 22, 2022

Tell us about your environment

Ruby Version: 3.1.1

Framework Version (Rails, whatever): Rails 7.0.2.3

Action Policy Version: 0.6.0

Reproduction Script: Use this template to
create a standalone reproduction script. That would help us to fix the problem quicker. Thanks!

What did you do?

Initialize project

What did you expect to happen?

Should work without errors

What actually happened?

Action Policy gives this deprecation warning
/home/appuser/vendor/bundle/ruby/3.1.0/gems/action_policy-0.6.0/lib/action_policy/ext/module_namespace.rb:24: warning: Refinement#include is deprecated and will be removed in Ruby 3.2

@palkan
Copy link
Owner

palkan commented Mar 22, 2022

Thanks for the report! Working on it.

@palkan palkan closed this as completed in 185bb3d Mar 22, 2022
@GoktugOzturk
Copy link
Contributor Author

Hi, I'm not sure if you're still working on this but wanted to write another comment since you closed this issue.
You've fixed some parts on the codebase with this commit
But module_namespace.rb still contains this problem.

Also, another minor release with the changes would be appreciated

GoktugOzturk added a commit to GoktugOzturk/action_policy that referenced this issue Apr 20, 2022
Fix refinement#include deprecation warning as I mentioned on palkan#207
palkan pushed a commit that referenced this issue May 24, 2022
Fix refinement#include deprecation warning as I mentioned on #207
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants