Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for refinement#include deprecation warning #208

Merged
merged 3 commits into from
May 24, 2022

Conversation

GoktugOzturk
Copy link
Contributor

@GoktugOzturk GoktugOzturk commented Apr 20, 2022

fixes #207 refinement#include deprecation warning

PR checklist:

  • Tests included
  • Documentation updated
  • Changelog entry added

Fix refinement#include deprecation warning as I mentioned on palkan#207
@GoktugOzturk GoktugOzturk changed the title Update module_namespace.rb Fix for refinement#include deprecation warning Apr 20, 2022
@GoktugOzturk
Copy link
Contributor Author

There is no need for test or documentation updates. Added line for changelog.

Also since Ruby 2,6 is EOL, maybe you can remove it from unittests. Seems like that is the only version that fails.

@GoktugOzturk
Copy link
Contributor Author

Also, can we release 0.6.1 so we can start using this without a field revision number?

added link for issue number
@palkan palkan merged commit 30d38a4 into palkan:master May 24, 2022
palkan pushed a commit that referenced this pull request May 24, 2022
@palkan
Copy link
Owner

palkan commented May 24, 2022

can we release 0.6.1

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deprecation warning with Ruby 3.1
2 participants