Skip to content

Commit

Permalink
Fix setup.py path in test. (#12881)
Browse files Browse the repository at this point in the history
The path is supposed to be relative to the BUILD file, but was
specified relative to the buildroot.

This test passed because src/python/foo/src/python/foo/setup.py
becomes foo/setup.py after stripping source roots (because
src/python/foo/src/python/ is recognized as a source root).
But that was still a bad example for any readers.

[ci skip-rust]

[ci skip-build-wheels]
  • Loading branch information
benjyw authored Sep 14, 2021
1 parent e02b59f commit fd71177
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/python/pants/backend/python/goals/setup_py_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ def test_use_existing_setup_script(chroot_rule_runner) -> None:
':foo',
],
provides=setup_py(
setup_script='src/python/foo/setup.py',
setup_script='setup.py',
name='foo', version='1.2.3'
)
)
Expand Down

0 comments on commit fd71177

Please sign in to comment.