[internal] Fix setup.py path in test. #12881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The path is supposed to be relative to the BUILD file, but was specified relative to the buildroot. This test passed because src/python/foo/src/python/foo/setup.py becomes foo/setup.py after stripping source roots (because src/python/foo/src/python/ is recognized as a source root). But that was still a bad example for any readers. [ci skip-rust] [ci skip-build-wheels]
benjyw
changed the title
Eric-Arellano
approved these changes
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The path is supposed to be relative to the BUILD file, but was
specified relative to the buildroot.
This test passed because src/python/foo/src/python/foo/setup.py
becomes foo/setup.py after stripping source roots (because
src/python/foo/src/python/ is recognized as a source root).
But that was still a bad example for any readers.
[ci skip-rust]
[ci skip-build-wheels]