Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NailgunStreamWriter probably shouldn't grab the socket without a lock #7653

Closed
ity opened this issue May 2, 2019 · 0 comments · Fixed by #9722
Closed

NailgunStreamWriter probably shouldn't grab the socket without a lock #7653

ity opened this issue May 2, 2019 · 0 comments · Fixed by #9722

Comments

@ity
Copy link
Contributor

ity commented May 2, 2019

NailgunStreamWriter probably shouldn't grab the socket without a lock

Within DaemonPantsRunner#_pipe_stdio(..) -
NailgunStreamWriter.open_multi(maybe_shutdown_socket.socket, types, ttys)
@patliu85 patliu85 mentioned this issue May 8, 2019
Closed
@stuhood stuhood mentioned this issue May 10, 2020
Merged
stuhood pushed a commit that referenced this issue May 13, 2020
Port the pantsd nailgun server to rust (#9722)
9506fbf 
### Problem

The setup and teardown of each request made to the nailgun server in `pantsd` had become quite complicated over time... and consequently, slower than it needed to be.

### Solution

Port `pantsd`'s nailgun server to rust using the `nails` crate. Additionally, remove the `Exiter` class, which had accumulated excess responsibilities that can instead be handled by returning `ExitCode` values. Finally, fix a few broken windows including: double logging to pantsd, double help output, closed file errors on pantsd shutdown, and redundant setup codepaths.

### Result

There is less code to maintain, and runs of `./pants --enable-pantsd help` take `~1.7s`, of which `~400ms` are spent in the server. Fixes #9448, fixes #8243, fixes #8206, fixes #8127, fixes #7653, fixes #7613, fixes #7597.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Port the pantsd nailgun server to rust stuhood/pants
1 participant
@ity