-
-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pantsd does not react well to truncated stdout #8243
Labels
Comments
This one is very weird, because it happens reliably, but only after a certain amount of ouput has been truncated:
|
stuhood
pushed a commit
that referenced
this issue
May 13, 2020
### Problem The setup and teardown of each request made to the nailgun server in `pantsd` had become quite complicated over time... and consequently, slower than it needed to be. ### Solution Port `pantsd`'s nailgun server to rust using the `nails` crate. Additionally, remove the `Exiter` class, which had accumulated excess responsibilities that can instead be handled by returning `ExitCode` values. Finally, fix a few broken windows including: double logging to pantsd, double help output, closed file errors on pantsd shutdown, and redundant setup codepaths. ### Result There is less code to maintain, and runs of `./pants --enable-pantsd help` take `~1.7s`, of which `~400ms` are spent in the server. Fixes #9448, fixes #8243, fixes #8206, fixes #8127, fixes #7653, fixes #7613, fixes #7597.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
./pants --enable-pantsd list :: | head
...seemingly exits cleanly. But the pantsd log does not show the run completing, and the next call in the same workspace will block with the:
...message, presumably because the first run did not exit cleanly.
The text was updated successfully, but these errors were encountered: