Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace fmt goal with v2 version #8351

Closed
illicitonion opened this issue Sep 27, 2019 · 0 comments · Fixed by #9257
Closed

Replace fmt goal with v2 version #8351

illicitonion opened this issue Sep 27, 2019 · 0 comments · Fixed by #9257

Comments

@illicitonion
Copy link
Contributor

This is blocked on #8345 and #8346 but then should mostly just be renaming the scope in #8350 and removing the v1 Goal from the goal registration code.
@illicitonion illicitonion mentioned this issue Sep 27, 2019
Merged
@Eric-Arellano Eric-Arellano mentioned this issue Mar 7, 2020
Merged
Eric-Arellano added a commit that referenced this issue Mar 10, 2020
@Eric-Arellano
Rename fmt2 to fmt and lint2 to lint (#9257)
77b120a 
Closes #8351.

It's safe to make this change, even with us defaulting to `--v2` for users, because we default to no V2 linters being enabled and the V2 goal no-ops in this case. 

It's also safe to have both V1 and V2 linters run at the same time (mixed mode). They won't run at the same time, so there's no risk of formatters conflicting with each other.

In a followup, we can now deprecate V1 isort for the V2 implementation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename fmt2 to fmt and lint2 to lint Eric-Arellano/pants
1 participant
@illicitonion